chore: drop the dead max_tokens from both e2e pipeline profiles - #359
Merged
Merged
Conversation
context-simple's `max_tokens` used to be a fallback consulted only when a provider published no context window, so in these profiles it was inert. It is now a CAP defaulting to None, and leaving the lines in place would clamp both pipelines to 300,000 tokens. The Gemini profile is the interesting one. Gemini's provider published no context window at all, so this 300,000 was genuinely live there -- the only place in the ecosystem where it was. provider-gemini now publishes its real 1,048,576-token window, so removing the line lets that pipeline use the whole model instead of 29% of it, which is the point. Both files re-parsed after the edit; the first attempt removed the orchestrator's `config:` key instead of the context manager's, and the parse check caught it. Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This was referenced Sep 15, 2026
Collaborator
Author
The five PRs in this coordinated changeMerge FIRST — independent of each other, any order:
Merge AFTER those three: The two config repos (4, 5) delete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
context-simple's
max_tokensused to be a fallback consulted only when a provider published no context window, so in these two e2e pipeline profiles it was inert. It is now a CAP defaulting toNone, and leaving the lines in place would clamp both pipelines to 300,000 tokens. This PR deletessession.context.config.max_tokensfromprofiles/attractor-e2e-pipeline-anthropic.yamlandprofiles/attractor-e2e-pipeline-gemini.yaml(2 lines, no other changes).The Gemini profile is the interesting one. Gemini's provider published no context window at all, so this 300,000 was genuinely live there — the only place in the ecosystem where it was.
provider-gemininow publishes its real 1,048,576-token window, so removing the line lets that pipeline use the whole model instead of 29% of it, which is the point.Verification checklist
max_tokensvalue. This diff changes no dispatch, admission, or event behavior; it removes two inert config lines from e2e profiles.engine.py/handler code (none touched). The changed path is the profile-to-context-manager seam, exercised instead by the cross-repo DTU run below.specs/EXTENSIONS.md: no entry needed — config-value removal in two e2e profiles, no observable contract change for pipeline authors or downstream consumers.48e000a5:CI Gate (all checks passed)reportspass, alongside DOT Render Gate, Opinionated Guards, Unit Tests (py3.11 + py3.13) and license/cla — 6/6 green, none bypassed.Verification evidence
Both files were re-parsed after the edit. The first attempt removed the orchestrator's
config:key instead of the context manager's, and the parse check caught it — the error was fixed before commit, and this is why the parse check exists.Repo suite:
Cross-repo DTU validation, instance
context-overflow-fix-20260915, all 8 target behaviors PASS. The headline result is exactly the one this PR's Gemini profile depends on: a Gemini session's effective budget goes from 200,000 (the old fallback) to 1,011,712 (its real published window), a 5.1x increase. Also:max_tokens: 500000caps to exactly 500,000; a cap above the model window is a no-op; andoverrides.context-simple.configinsettings.yamlnow reachessession.contextthrough the CLI's ownresolve_bundle_config.Notes for reviewers
This is part 5 of a coordinated five-repo change and must merge after
context-simple,provider-geminiandapp-cli. If merged beforecontext-simple, the deletion restores the old inert-fallback behavior and the Gemini pipeline keeps the 200,000 fallback — not harmful, but the intended gain does not land until the ordering holds. Cross-links to the other four PRs are in a follow-up comment.Coordinated five-repo change
max_tokensincontext-simplewas documented as "Maximum context size" but implemented as a fallback consulted only when a provider published no context window. Orchestrators always pass a provider, so the knob was silently dead in production. It is now a real cap (defaultNone= no cap); a newmax_tokens_fallback(default 200,000) took over the fallback role.Merge order matters
Merge FIRST (independent of each other, any order):
amplifier-module-context-simple—feat/max-tokens-capamplifier-module-provider-gemini—feat/publish-context-windowamplifier-app-cli—feat/session-module-config-overridesMerge AFTER those three:
4.
amplifier-foundation—chore/drop-dead-max-tokens5.
amplifier-bundle-attractor—chore/drop-dead-max-tokensRationale: the two config repos delete
max_tokenslines that only become safe-to-delete once context-simple's new semantics are in.Cross-repo verification
DTU instance
context-overflow-fix-20260915, all 8 target behaviors PASS:max_tokens: 500000caps to exactly 500,000.settings.yamloverrides.context-simple.confignow reachessession.contextthrough the CLI's ownresolve_bundle_config.test_image_vision_integration_with_real_api, needs a liveGOOGLE_API_KEY, fails onmaintoo)test_grpc_adapter_main.py::TestVerifyModuleType::test_non_isinstance_object_with_mount_passes, verified failing onmainbefore the change)