Fix selected configured model reporting in headless output and session metadata - #364
Merged
Brian Krabach (bkrabach) merged 1 commit intoOct 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Actual headless CLI qualification with OpenAI SDK 3.22.1 found that selecting a non-first mounted provider sent the correct request but reported the first provider's model in JSON and saved session metadata. The initial
--provider openai --model gpt-4.1fixture reached gpt-4.1 while reporting vllm/meta-llama/Llama-3-8B. Four new Sol/Astra JSON/json-trace tests reproduced the same defect in both output and real SessionStore reloads before repair.Bounded repair
Trade-off: a scalar configured-default label does not summarize multi-model role routing. This PR makes its provenance explicit rather than adding unscoped event inference or changing selection.
Verification
Exact candidate 2b64f76; existing task-owned Linux-aarch64 DTU; Python 3.13.15, Core 2.0.1, Foundation 89575c3482e3e8afe5a03df72e723cf815fa1f6c, SDK 3.22.1. Normal package resolution and non-editable CLI wheel.
The coupled vLLM SDK repair is microsoft/amplifier-module-provider-vllm#46 at 86d7d8ebcff4ba95427aa60bc0880d4632962b0e. Its own 333-test four-SDK matrix and all eight CI jobs are green. Neither PR is merged or installed on the live host by this qualification.
Limits: controlled local server, not real hosted model inference or production vLLM deployment; headless single-shot paths, not full interactive UX. An archive install's version banner falls back to 0.1.0 without .git; package metadata remains 0.1.1 and exact source identity is established by hashes, not the banner. Preserve initial failing receipts rather than relabeling them.