fix: refresh module caches by source identity - #360
Merged
Merged
Conversation
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
module_updatecould report a successful refresh while leaving the stale cache in place when a module entry or bundle name differed from the repository name. It also selected cache entries by a derived semantic name, which could remove an unrelated repository or ref with the same label.Fix
GitSourceHandler.update()using the exact configured repository URL and ref under Foundation's cache lock..gitURLs, ref/repository isolation, failure propagation, and selective Click update behavior.AGENTS.md.Verification
uv run pytest tests/test_module_cache.py— 9 passed.Cross-platform CI passed: https://github.com/microsoft/amplifier-app-cli/actions/runs/35960784045 (all eight test jobs passed across Ubuntu, macOS, and Windows; CLA passed). No merge or auto-merge is enabled by this PR.