fix: preserve fork cost boundaries without copying parent events - #355
Merged
Merged
Conversation
Persist verified inherited-cost boundaries during both fork paths; restore only the boundary plus child-owned CI cost, never mutable ancestors. Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
fork_cost_boundaryin child native metadata, so cost reporting accounts for parent-through-fork history plus child-owned cost without reconstructing ancestors.--no-eventsas a compatibility option.Why
Forked sessions need accurate inherited-cost accounting without copying parent-owned artifacts or assigning ownership incorrectly.
Verification
4e1688d2d53daeb5e03ae710d2eb9b9e22d2ee27and approved it after the final test condition was met.Limitations / caveats
Breaking changes
None.