Add code complexity report and quality checks with ratcheting cap#2597
Draft
robgruen wants to merge 11 commits into
Draft
Add code complexity report and quality checks with ratcheting cap#2597robgruen wants to merge 11 commits into
robgruen wants to merge 11 commits into
Conversation
… And added to build-ts to gate builds.
…ibute sanitization' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…rosoft/TypeAgent into dev/robgruen/code_complexity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces automated quality gates and reporting for TypeScript code by adding new scripts, dependencies, and CI workflow steps. These changes enforce stricter code quality standards on pull requests, including complexity, lint, circular dependencies, and test debt, while also ensuring generated reports are properly ignored in version control.
CI Workflow Enhancements:
.github/workflows/build-ts.ymlto automatically check for increases in code complexity, lint errors, circular dependencies, and test debt compared to the base branch. These steps use new scripts and enforce that quality metrics can only improve or stay the same over time.New Scripts and Reporting:
ts/package.jsonfor code quality checks and report generation, includingcode-complexity,code-lint,code-circular,code-debt, and others. These scripts run TypeScript-based tools to generate reports and enforce gates.knip.jsoncconfig file for dead code analysis, supporting the new dead code report script.Dependency Updates:
ts/package.jsonandts/tools/package.json, includingeslint,eslint-plugin-sonarjs,jscpd,knip,madge, andtypescript-eslint. [1] [2]ts/package.json, replacingprotobufjswithonnxruntime-node..gitignore Updates:
ts/.gitignoreto exclude all generated code quality report outputs from version control, preventing accidental commits of large or sensitive report files.