Fix SNR calculate error, total_snrlevels, requirements.txt - #22
Open
Changhun Kim (drumpt) wants to merge 2 commits into
Open
Fix SNR calculate error, total_snrlevels, requirements.txt#22Changhun Kim (drumpt) wants to merge 2 commits into
Changhun Kim (drumpt) wants to merge 2 commits into
Conversation
Changhun Kim (drumpt)
commented
Oct 10, 2021
Changhun Kim (drumpt)
commented
- I think np.sqrt in line 68 of audiolib.py should be removed in order to get correct snr.
- total_snrlevels should be a integer parameter in np.linspace(snr_lower, snr_upper, total_snrlevels) (line 47 of noisyspeech_synthesizer.py)
- I removed unnecessary standard library "os" and changed glob to glob2 to accurately download libraries in requirements.txt
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.