Integrate "get model versions" and "download specific model version" into cpp Core with max_versions#816
Open
selenayang888 wants to merge 25 commits into
Open
Integrate "get model versions" and "download specific model version" into cpp Core with max_versions#816selenayang888 wants to merge 25 commits into
selenayang888 wants to merge 25 commits into
Conversation
…o baijumeswani/catalog
…/integrate-get-model-versions-into-cpp
…odel-versions-into-cpp
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Copilot stopped reviewing on behalf of
selenayang888 due to an error
June 18, 2026 01:49
skottmckay
reviewed
Jun 18, 2026
skottmckay
reviewed
Jun 18, 2026
skottmckay
reviewed
Jun 24, 2026
…odel-versions-into-cpp
skottmckay
reviewed
Jun 26, 2026
skottmckay
reviewed
Jun 26, 2026
…odel-versions-into-cpp
… the default list"
skottmckay
reviewed
Jun 30, 2026
Comment on lines
+56
to
+57
| /// Returns the variants (in any order; the base class sorts/indexes them) | ||
| /// for the given alias. |
Collaborator
There was a problem hiding this comment.
These should automatically be sorted by AddVariant so should be in the same priority order as the model list output.
| } | ||
|
|
||
| container.SelectDefaultVariant(); | ||
| version_query_models_[model_alias] = std::make_unique<Model>(std::move(container)); |
Collaborator
There was a problem hiding this comment.
If someone had previously queried for this alias this line is going to invalidate the previously returned flModelList. The comment in the C and C++ code says that never happens.
Comment on lines
+439
to
+443
| // Sort into best-first order. Within the same variant name, device priority is identical, | ||
| // so this also groups by name with latest version first — suitable for max_versions capping. | ||
| std::stable_sort(result.begin(), result.end(), [](const Model* a, const Model* b) { | ||
| return Model::CompareBestFirst(*a, *b); | ||
| }); |
Collaborator
There was a problem hiding this comment.
I didn't expect sorting would be required here as Model::AddVariant sorts on insert to keep the vector of variants in the priority order, so you should be able to use the list returned from Model::Variants() as-is.
Collaborator
|
Will the other language bindings have GetModelVersions exposed in this PR or a separate one? AI should be able to handle adding that fairly easily. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Porting the changes "get model versions" and "download specific model version" from C# into C++ Core now: