Skip to content

docs(odsp-driver): add changeset for Node 24 compatibility fix - #28203

Merged
Lindsey Nguyen (lindsnguyen) merged 1 commit into
microsoft:mainfrom
lindsnguyen:test/lindsnguyen/odsp-compact-offset
Sep 11, 2026
Merged

Lindsey Nguyen (lindsnguyen) merged 1 commit into
microsoft:mainfrom
lindsnguyen:test/lindsnguyen/odsp-compact-offset

Conversation

@lindsnguyen

Copy link
Copy Markdown
Contributor

Description

Adds the missing changeset for the compact snapshot parsing fix in PR #28194.

Although the implementation change is internal, it fixes a consumer-visible compatibility issue where valid compact snapshots could fail to load with pooled buffers returned by Node.js 24.18 and later.

Copilot AI lite review requested due to automatic review settings September 11, 2026 00:03
@github-actions

Copy link
Copy Markdown
Contributor

Bundle size comparison

Base commit: could not be determined; will be reported when the comparison runs
Head commit: 251dc52c053db08cd6213e7e0a0fdc7e25a03f30

Pending — Build - client packages is running. Results will appear here when the build completes.

@github-actions

Copy link
Copy Markdown
Contributor

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (9 lines, 1 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review issues remain.

Pull request overview

Adds the missing ODSP driver changeset for Node.js 24.18+ compact snapshot compatibility.

Changes:

  • Adds release metadata for @fluidframework/odsp-driver.
  • Documents support for pooled, non-zero-offset Uint8Array views.
File summaries
File Description
.changeset/fix-pooled-snapshot-buffers.md Documents the consumer-facing ODSP driver compatibility fix.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@lindsnguyen
Lindsey Nguyen (lindsnguyen) merged commit 64a2289 into microsoft:main Sep 11, 2026
25 checks passed
Lindsey Nguyen (lindsnguyen) added a commit to lindsnguyen/FluidFramework that referenced this pull request Sep 11, 2026
…soft#28203)

## Description

Adds the missing changeset for the compact snapshot parsing fix in [PR
microsoft#28194](microsoft#28194).

Although the implementation change is internal, it fixes a
consumer-visible compatibility issue where valid compact snapshots could
fail to load with pooled buffers returned by Node.js 24.18 and later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants