fix: resolve audit vulns via overrides and add Puppeteer Edge fallback - #113
Merged
Hector Hernandez (hectorhdzg) merged 2 commits intoAug 11, 2026
Conversation
- Add durable overrides for brace-expansion, js-yaml (nested 3.x for grunt), linkify-it, markdown-it, morgan and ws to clear 7 npm audit findings (0 vulnerabilities). - gruntfile: add CI-gated _getBrowserExecutablePath() helper that falls back to installed Microsoft Edge locally (avoids Defender/WDAC blocking Puppeteer's unsigned Chromium); returns undefined under TF_BUILD/CI so official builds keep bundled Chromium. Wire executablePath into both puppeteer blocks.
A fresh install (no committed lockfile) pulled the latest @types/node whose new ffi.d.ts uses syntax that the repo's pinned TypeScript 4.9.5 cannot parse, breaking the Node 20/22 CI build. Pin it via overrides to a pre-ffi.d.ts version.
Radhika Gupta (rads-1996)
approved these changes
Aug 11, 2026
Jackson Weber (JacksonWeber)
approved these changes
Aug 11, 2026
Hector Hernandez (hectorhdzg)
merged commit Aug 11, 2026
70b986f
into
microsoft:main
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add durable overrides for brace-expansion, js-yaml (nested 3.x for grunt), linkify-it, markdown-it, morgan and ws to clear 7 npm audit findings (0 vulnerabilities).
gruntfile: add CI-gated _getBrowserExecutablePath() helper that falls back to installed Microsoft Edge locally (avoids Defender/WDAC blocking Puppeteer's unsigned Chromium); returns undefined under TF_BUILD/CI so official builds keep bundled Chromium. Wire executablePath into both puppeteer blocks.