Consolidate open Dependabot updates into one dependency bump - #773
Open
gfs wants to merge 1 commit into
Open
Conversation
Folds the five open Dependabot pull requests for the VS Code extension (#765, #766, #767, #768, #769) into a single change so the new .github/dependabot.yml grouping starts from a clean slate. Transitive lockfile bumps: linkify-it 5.0.1 -> 5.0.2, fast-uri 3.1.2 -> 3.1.4, undici 7.24.6 -> 7.29.0, and brace-expansion 1.1.14 -> 1.1.16 and 5.0.5 -> 5.0.8. Three of the versions Dependabot picked no longer exist: brace-expansion 1.1.18 and 5.0.9 (from #769 and #767) and minimatch 10.2.6 (pulled in by #767) have been removed from the npm registry, so restoring them fails with a 404 and the packument no longer records them at all. They are pinned here to the newest releases that do exist -- 1.1.16, 5.0.8 and 10.2.5. The vscode-languageclient 7.0.0 -> 10.1.0 bump from #767 does not build on its own, so it is carried here with the migration it needs: * vscode-languageclient 10 declares its entry points only through "exports", which node10 module resolution cannot see, so both TypeScript projects move to node16 module resolution. * Its type declarations use the NoInfer utility type, so typescript goes from ^4.5.5 to ^5.9.3. * LanguageClient.start() now returns a promise rather than a disposable and onReady() was removed in v8, so client/extension.ts registers its notification handlers before starting the client and disposes the client through the extension context. * vscode-languageclient 10 requires VS Code ^1.91.0, so engines.vscode goes from ^1.63.0 to ^1.91.0 and @types/vscode is pinned to the matching 1.91.0 so the extension is not type-checked against APIs newer than the version it claims to support. Verified with npm ci in both package directories, npm run compile, npm run lint, and the esbuild bundle step used for packaging. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c4d8e4b0-da9f-459c-9620-b7c0d2af33a6
gfs
force-pushed
the
gfs-consolidate-dependabot-bumps
branch
from
August 3, 2026 18:37
9bd852b to
32b3fd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folds the five open Dependabot pull requests for the VS Code extension into a single change, so the new
.github/dependabot.ymlgrouping (#770) starts from a clean slate.Supersedes #765, #766, #767, #768 and #769 — GitHub's closing keywords only auto-close issues, not pull requests, so those five need closing by hand (or Dependabot will retire them itself on its next run once these versions are on
main).Straightforward bumps
Cherry-picked as-is from the Dependabot branches:
linkify-it5.0.1 → 5.0.2fast-uri3.1.2 → 3.1.4undici7.24.6 → 7.29.0brace-expansion1.1.14 → 1.1.16 and 5.0.5 → 5.0.8🚩 Three of Dependabot's pins point at versions that no longer exist
brace-expansion1.1.18 and 5.0.9 (#769, #767) andminimatch10.2.6 (pulled in by #767) have been removed from the npm registry. The packument no longer records them even in itstimefield, and the tarballs 404 on every mirror — including the pipeline's ownPublicRegistriesFeed:The first push of this branch reproduced exactly that failure in
DevSkim-VSCode-PR, which is also what #767 and #769 would have hit had the Azure DevOps pipelines run on Dependabot's branches. They're pinned here to the newest releases that do exist — 1.1.16, 5.0.8 and 10.2.5 (currentlatestfor both packages).Worth knowing independently of this PR: Dependabot can pin versions that later vanish, and nothing in the current setup notices until a build breaks.
The other one that wasn't straightforward: #767
#767 also bundled a major
vscode-languageclient7 → 10 bump, which does not build on its own. It's carried here with the migration it needs:node16module resolution.vscode-languageclient10 droppedmain/typesand declares its entry points only throughexports, which node10 resolution can't see —tscfails withCannot find module 'vscode-languageclient/node'. Bothtsconfig.jsonfiles move tomodule/moduleResolution: node16. The client has no"type": "module", so it still emits CommonJS, matching theesbuild --format=cjsbundle step.typescript^4.5.5→^5.9.3. The v10 type declarations use theNoInferutility type (TypeScript 5.4+); with 4.9.5 you get ~40TS2304: Cannot find name 'NoInfer'errors out ofnode_modules.client/extension.tslifecycle migration.LanguageClient.start()returnsPromise<void>instead of aDisposable, andonReady()was removed in v8. Notification handlers now register beforestart()— v10 queues them in_pendingNotificationHandlersand wires them when the connection opens, so nothing sent during initialization can be missed — and the client itself goes intocontext.subscriptions.engines.vscode^1.63.0→^1.91.0(root and client), whichvscode-languageclient10 requires.@types/vscodeis pinned to the matching 1.91.0 rather than floating to latest, so the extension isn't type-checked against APIs newer than the version it claims to support.That's the unavoidable cost of
vscode-languageclient10 and the main thing worth a second opinion on. Ping me if you'd rather split the migration out and land only the mechanical bumps.Verification
npm ciin bothDevSkim-VSCode-Plugin/andDevSkim-VSCode-Plugin/client/— every integrity hash verifiesnpm run compile(tsc -b) — cleannpm run lint(eslint ./client) — cleannpm run esbuild-base— bundles at 959.4 kbNot verified here: the extension end-to-end against the language server. The .NET server uses
OmniSharp.Extensions.LanguageServer0.19.9 (LSP 3.16/3.17) and the client now speaks protocol 3.18. That's backwards compatible by design — capabilities are negotiated — but a manual smoke test in the Extension Development Host is worth doing before merge, since there's no automated integration coverage.Note on lockfile provenance
registry.npmjs.orgisn't reachable from my environment, only an Azure Artifacts mirror. So rather than regenerating lockfiles (which would have rewrittenresolvedURLs to the mirror and downgradedsha512integrity to the mirror'ssha1shasums), I kept Dependabot's entries and hand-edited only the lines that changed —typescript,@types/vscode, and the three repinned packages above.Their
sha512values were computed from the actual tarballs. The method was cross-checked againstundici7.29.0 andbrace-expansion5.0.8, whose hashes reproduce Dependabot's exactly, and the whole tree then verified with a realnpm ciin both directories.Changelog
Entry added under
[1.0.96], fromnbgv get-version -v SimpleVersionon this branch rebased onmain(mainis 1.0.95). If other PRs merge ahead of this one the git height shifts, so the heading needs a re-check before merging.