Rename TempCustomMigrationTableBuffer back to CustomMigrationTableBuffer - #9700
Merged
Merged
Conversation
The variable is only a handle to call SaveMigrationTableMapping (its fields are never read/written; the method persists to Migration Setup / Replication Table Mapping). PR #9200 renamed it to TempCustomMigrationTableBuffer, which is misleading and trips AA0237 under stricter rulesets (e.g. NAV). Restores the pre-#9200 name, matching the NAV 28.x backport and PR #9663.
github-actions
Bot
added
AL: Apps (W1)
gggdttt
marked this pull request as ready for review
July 23, 2026 14:38
gggdttt
enabled auto-merge
July 23, 2026 14:41
darjoo
approved these changes
Jul 24, 2026
auto-merge was automatically disabled
July 27, 2026 08:00
Pull request was closed
gggdttt
enabled auto-merge
July 27, 2026 09:18
haoranpb
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames
TempCustomMigrationTableBufferback toCustomMigrationTableBufferinAddCustomMigrationMapping.Page.al(declaration + both call sites).Why
The variable is only a handle used to call
SaveMigrationTableMapping— its own fields are never read or written; the method persists to theMigration Setup Table Mapping/Replication Table Mappingtables. PR #9200 renamed it toTempCustomMigrationTableBuffer, which is misleading (it isn't used as a data buffer) and tripsAA0237("non temporary variables must not be prefixed with Temp") under stricter rulesets — e.g. the NAV build, where AA0237 is an error rather than a warning.This restores the pre-#9200 name, keeping
mainconsistent with the NAV 28.x backport and PR #9663.Risk
None — the change is naming-only and behavior-preserving.
AB#642621