Skip to content

Add doNotPerformUpgrade setting and enhance upgrade warning messages#2327

Open
ChrisBlankDe wants to merge 12 commits into
microsoft:mainfrom
ChrisBlankDe:disc2296
Open

Add doNotPerformUpgrade setting and enhance upgrade warning messages#2327
ChrisBlankDe wants to merge 12 commits into
microsoft:mainfrom
ChrisBlankDe:disc2296

Conversation

@ChrisBlankDe

@ChrisBlankDe ChrisBlankDe commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

❔What, Why & How

This pull request introduces a new pipeline setting, doNotPerformUpgrade, which allows users to skip the upgrade phase in Run-AlPipeline while continuing to publish and test apps. The setting is integrated into the configuration schema, documented for users, and tested for presence in the schema. Additionally, warning messages related to upgrade testing have been improved for clarity.

New Feature: Skip Upgrade Phase

  • Added a new doNotPerformUpgrade boolean setting to the default settings in ReadSettings.psm1, the pipeline schema (settings.schema.json), and pipeline parameter list in RunPipeline.ps1, allowing users to bypass the upgrade phase during pipeline execution.
  • Documented the new setting in RELEASENOTES.md and Scenarios/settings.md, explaining its purpose and usage.
  • Added a test to ensure doNotPerformUpgrade is present in the settings schema.

Pipeline Usability Improvements

  • Enhanced warning messages in RunPipeline.ps1 to clarify that missing previous release apps disables the AppSourceCop breaking change check.

Original PR #2297 was reverted with PR #2305. This PR matches the original, with the additional initialization of the settings.

Related to issue: #2296

✅ Checklist

  • Add tests (E2E, unit tests)
  • Update RELEASENOTES.md
  • Update documentation (e.g. for new settings or scenarios)
  • Add telemetry

@ChrisBlankDe
ChrisBlankDe requested a review from a team as a code owner July 22, 2026 11:58
Copilot AI review requested due to automatic review settings July 22, 2026 11:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds doNotPerformUpgrade to skip upgrade execution while retaining publishing and testing behavior.

Changes:

  • Adds and forwards the new pipeline setting.
  • Updates upgrade-related warnings and documentation.
  • Adds schema validation coverage.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Actions/.Modules/ReadSettings.psm1 Initializes the setting to false.
Actions/.Modules/settings.schema.json Defines the boolean setting.
Actions/RunPipeline/RunPipeline.ps1 Forwards the setting and clarifies warnings.
Tests/ReadSettings.Test.ps1 Verifies schema presence and type.
Scenarios/settings.md Documents the setting.
RELEASENOTES.md Announces the feature.

Comment thread Actions/.Modules/settings.schema.json
Comment thread Scenarios/settings.md Outdated
Comment thread RELEASENOTES.md
Copilot AI review requested due to automatic review settings July 22, 2026 12:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Comment thread Tests/ReadSettings.Test.ps1 Outdated
Comment thread Tests/ReadSettings.Test.ps1 Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 22, 2026 13:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

Tests/ReadSettings.Test.ps1:547

  • Close the new It block before the existing validation test. As written, the second It is nested and the file ends with an unmatched {, so this Pester file cannot be parsed or run.
            It 'ValidateSettings skips validation entirely on PS versions less than 7 without warning' {

Copilot AI review requested due to automatic review settings July 22, 2026 13:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings July 22, 2026 13:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings July 22, 2026 13:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.

@mazhelez
mazhelez self-requested a review July 22, 2026 18:54
mazhelez
mazhelez previously approved these changes Jul 23, 2026
…ine in ReadSettings.Test.ps1

Copilot-Session: 2add9b5c-0d44-4b0e-a260-c25400a7bc05
Copilot AI review requested due to automatic review settings July 23, 2026 09:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

@aholstrup1
aholstrup1 requested a review from mazhelez July 23, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants