Fix local test config path and quote build-local output#411
Open
Aniket-pd wants to merge 1 commit into
Open
Conversation
|
Welcome to the Microcks community! 💖 Thanks and congrats 🎉 for opening your first pull request here! Be sure to follow the pull request template or please update it accordingly. Hope you have a great time there! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two small issues that show up when working on the CLI locally.
The first is in
cmd/context_test.go.TestDeleteContextwas writing to./testdata/local.config, which fails when that directory is missing. This change switches the test tot.TempDir()so it stays self-contained and does not depend on repository state.The second is in
make build-local. The build output path was not quoted, so it breaks when the checkout path contains spaces. This updates the target to create the output directory first and quote the-opath.I used the following checks locally:
go test ./...make build-localBoth pass from a checkout located in a path with spaces.