Fix flaky websocket tests by disabling keepalive - #657
Open
michaelhly wants to merge 1 commit into
Open
Conversation
test_multiple_subscriptions intermittently failed with ConnectionClosedError: no close frame received or sent. The websockets asyncio client aborts the socket when its keepalive ping (every 20s) goes unanswered within 20s. Under pytest-xdist all workers share one test validator, so the event loop / validator pubsub can stall past that window and the connection is killed mid-test. Disable keepalive on these short-lived test connections (ping_interval=None) and make the multiple_subscriptions teardown best-effort so a dead socket can't mask the test's real outcome. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #657 +/- ##
=======================================
Coverage 90.47% 90.47%
=======================================
Files 27 27
Lines 2508 2508
=======================================
Hits 2269 2269
Misses 239 239 🚀 New features to boost your workflow:
|
Collaborator
|
Should this PR continue moving forward? |
Owner
Author
The |
Collaborator
I haven't observed any instability in the WebSocket tests, this is indeed puzzling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.