Repository navigation
Count chains over the graph wherever only the count is wanted - #46
Merged
Merged
Conversation
Diagnosis stopped listing chains in #44, but three commands still listed every chain the model allows only to count it: model validate --write-scenarios (twice: once to print, once for the file's scenario_count), model diff, and the staleness check in model validate, which expanded the whole sidecar to read its hash. scenarios.CountChains counts by the DP diagnosis uses, falling back to listing on a cycle, and scenarios.SiblingHash reads only the hash. Six tiers count in 18 ms (listing took 3.2 s) and ten, 354 million chains, in 73 ms. The storefront still counts 14,429, its committed scenario_count. The how-it-works page still said diagnosis expands every chain and advised meta.scenarios: none past seven tiers; it now says what is true. The benchmark's table is re-measured: its chain counts predated the duplicate removal of #43.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up to T2 (#44). Diagnosis stopped listing chains there, but three commands still listed every chain the model allows just to count them.
What changes
These sites used to list every chain:
model validate --write-scenariosscenario_count.model validatestaleness checkmodel diffNow:
scenarios.CountChainscounts with the DP that diagnosis uses. On a cycle it falls back to listing.scenarios.SiblingHashreads only the sidecar's hash. It keeps the full reader's error for an unknown format.The listings that really walk chains are unchanged:
simulate --from-scenarios, the MCP scenario listings, and incident scenario matching.Speed (
BenchmarkScale, newcountcase)Docs
how-it-works.mdstill said diagnosis expands every chain, and advisedmeta.scenarios: nonepast seven tiers. It now states the current cost.Verified
CountChainsagainstExpand. A cycle test pins the fallback, and aSiblingHashtest covers both formats, an absent file, and an unknown format.go test ./...andmkdocs build --strictpass.scenario_count.