Feat/externalize app configs - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new centralized configuration mechanism for business and infrastructure properties using type-safe configuration classes, improves documentation for configuration and setup, and implements robust pagination configuration and testing. The main themes are configuration management, pagination support, and documentation clarity.
Configuration Management Improvements:
LoanProperties,SecurityProperties, andPaginationPropertiesas@ConfigurationPropertiesrecords, and enabled them in the main application (BiblioNodeApplication.java). This allows for externalized, validated, and easily maintainable configuration. [1] [2] [3] [4]AuthServiceImpl,LoanServiceImpl) and their tests to use the new configuration properties, improving maintainability and testability. [1] [2] [3] [4] [5] [6] [7]Pagination Support:
PaginationConfigto globally enforce default and maximum page sizes for pageable endpoints, and to document these defaults in OpenAPI/Swagger UI.PaginationIntegrationTestto verify default and max page size enforcement in API responses.application.yaml,application-dev.yaml,application-test.yaml). [1] [2] [3]Documentation and Setup Enhancements:
README.mdwith a dedicated Configuration section, improved setup instructions, and clearer references to configuration and API documentation. Also clarified terminology around DTO/entity separation and persistence optimizations. [1] [2] [3]Minor Improvements:
These changes together improve the maintainability, clarity, and robustness of configuration and pagination in the application, while making setup and documentation more user-friendly.