Repository navigation
fix(steamvr): take SteamVR's own grip offset off Touch controllers - #10
Merged
aaf2tbz merged 2 commits intoNov 18, 2026
Merged
Conversation
SteamVR's render models for every Touch controller (CV1, Rift S, Quest 2, Touch Plus and Touch Pro) put their openxr_grip component 20.6 degrees about x from the controller's frame, at +-0.007, -0.0018, 0.102 (x mirrored for the right hand), and SteamVR's OpenXR rebuilds the grip from it. The driver took 60 degrees off instead, which is the angle between openxr_grip and openxr_aim (-39.4), so SteamVR's controllers sat tilted and offset from the grip the headset reported, which showed as wrong wrist rotation.
6 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With Quest 3 controllers in SteamVR, wrist rotation was slightly off.
To give SteamVR the Touch controllers' own frame, the driver takes the grip offset off ALVR's grip pose: 60° about x, at (0, -0.032, 0.040). SteamVR's render models for every Touch controller (
oculus_cv1_controller,oculus_rifts_controller,oculus_quest2_controller,oculus_quest_plus_controller,oculus_quest_pro_controller) put theiropenxr_gripcomponent 20.6° about x from that frame, at (±0.007, -0.0018, 0.102) with x mirrored for the right hand, and SteamVR rebuilds the grip from it. The 60° is the angle betweenopenxr_grip(20.6°) andopenxr_aim(-39.4°), so SteamVR's grip ended up about 39° from the one the headset reported.The driver now takes off SteamVR's own
openxr_griptransform, so an application gets back the grip the headset sent. Only the Touch family changes; Lighthouse controllers already report their own frame.Testing
Built for macOS and for Windows (
build/native,build/win64): not run, no CMake or Ninja on this Mac.steamvr/driver_metalvr.dllwas built withx86_64-w64-mingw32-g++16.2 from the CMake target's sources, include paths and flags (C++20,-Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers, static runtime): 0 warnings, as onmain. CI covers the full builds.scripts/test-native.shandscripts/test-failures.sh: not run. They do not reach the SteamVR driver, andtests/has no harness for it yet, so this change has no automated check; happy to add one if there is a preferred shape for it.scripts/test-wine.sh: not run.scripts/test-openvr.sh: not run (this is the SteamVR driver, not the OpenComposite path).On a headset: Meta Quest 3 over Wi-Fi with the ALVR client, metalvrd from the v0.2.1 release (ALVR server v20.14.1), SteamVR 2.18.4 on MetalSharp Wine 8.0 (Wine 11.17, x86_64 under Rosetta), Apple silicon Mac, macOS 27. Tried in SteamVR Home and Blade & Sorcery.
Before: wrist rotation was slightly off. After: it matched the real controllers.
Checklist
patches/, not edits inexternal/