Repository navigation
feat(library): game settings from the Collection grid - #817
Merged
Merged
Conversation
A game's settings (Graphics, Runtime, Advanced, Presentation) opened only from the front card spread's gear, so a game far down a large library had to be paged to first (#799). Each Collection card now has a gear in its corner that selects the game and opens the same settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the latest request on #799: per-game advanced settings should be reachable from the grid list, not only from the front card spread. With 200+ games in a GOG library, paging to a game with the arrow takes a long time.
Changes
ui.rs: each Collection card gets a round gear button in its top-right corner. It selects the game, opens the same game settings popup as the hero's gear (Graphics, Runtime, Advanced, Presentation), and loads the game's tuning.PR Readiness (MANDATORY)
/Users/...paths introducedTest notes
cargo check --testspasses on Linux with the macOS-only FFI stubbed in a scratch copy.cargo fmt --checkis clean.Generated by Claude Code