Repository navigation
feat(library): remove a Windows program from the Steam Deck view - #816
Merged
Merged
Conversation
The Steam Deck view's art menu offered "Uninstall…" for GOG and Epic games only, so a Windows program could be removed only from its settings in the Collection view (#809). It now offers "Remove from Library…" for a Windows program and "Uninstall…" for a Game Jolt game, once they are not running, through the same Sharp Library actions as the Collection view: a program leaves the library and keeps its files and prefix; a Game Jolt game's folder is deleted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #809. In the Steam Deck view, the hero and card art menu offered "Uninstall…" for GOG and Epic games only. A Windows program could only be removed from its settings in the Collection view.
Changes
ui.rs: the art menu adds an entry for the Windows Programs page once the entry isn't running:The confirmation says what each one does:
sharp_deck.rs:deck_uninstallhandleswindows(/sharp-library/uninstall, which is what the Collection view's Uninstall calls) andgamejolt(/gamejolt/uninstall, using the entry'sinstall_dir).sharp_live.rs:uninstall_appanduninstall_gamejoltare nowpub(super)so the deck can call them.PR Readiness (MANDATORY)
/Users/...paths introducedTest notes
cargo check --testspasses on Linux with the macOS-only FFI stubbed in a scratch copy.cargo fmt --checkis clean.Generated by Claude Code