Skip to content

fix(settings): offer Uninstall FEX / x86_64 for a runtime that is only downloaded - #815

Merged
aaf2tbz merged 2 commits into
mainfrom
fix/uninstall-runtime-rows
Nov 20, 2026
Merged

aaf2tbz merged 2 commits into
mainfrom
fix/uninstall-runtime-rows

Conversation

@aaf2tbz

@aaf2tbz aaf2tbz commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes #813. Settings > Advanced already has "Uninstall FEX" and "Uninstall x86_64", but they showed up only when both runtimes were fully installed. A runtime that was downloaded but never finished setup (the FEX runtime in #811) didn't count. That left "Uninstall MetalSharp" as the only way to remove its download, so it looked like no per-build uninstall existed.

Changes

  • wine_runtime.c: new ms_wine_runtime_present(). It's true when the runtime is installed, or when its app in runtime/, its download in downloads/ or its kept-aside files are on disk. /runtime/state now reports it as present for each runtime.
  • settings_preview.rs:
    • The inactive runtime's uninstall row shows whenever that runtime is present.
    • The active runtime's row shows only when the other runtime is installed to switch to, as before.
    • A backend without present falls back to installed.
  • The backend's uninstall needed no change: it already removed an inactive runtime in any state.
  • runtime_routes_test.c: regression test. With only the inactive runtime's download on disk, it checks:
    • /runtime/state reports that runtime installed:false, present:true
    • uninstalling it removes the download without switching runtimes

PR Readiness (MANDATORY)

  • Real-game launch test completed for game/runtime/graphics/compatibility changes: N/A (Settings and runtime state only)
  • No hardcoded paths, secrets, or absolute /Users/... paths introduced
  • Config/rules TOML validated: N/A
  • Version metadata in sync: N/A (no bump)
  • Bottle/runtime migration and launch behavior preserved
  • Docs / compatibility matrix updated for user-facing changes: N/A
  • Regression test added for each bug fix

Test notes

  • Not run on a Mac. The session had no macOS: neither make -C app/src-c test nor package-app.sh was run. CI and a local run should cover this before merge.
  • Type checks: cargo check --tests of app-gpui passes on Linux. The macOS-only FFI was stubbed in a scratch copy for this, not in the branch. cargo fmt --check is clean.
  • C changes: clang -fsyntax-only reports no errors in the changed code; the only errors come from existing Darwin-only APIs. git clang-format --diff is clean.
  • Not exercised: the new test itself, which builds only on macOS.

Generated by Claude Code

…y downloaded

Settings > Advanced offered "Uninstall FEX" and "Uninstall x86_64" only when
both runtimes were fully installed. A runtime that was downloaded but whose
setup never finished (FEX's, in #811) left no way to remove its download but
"Uninstall MetalSharp", so it looked as if the per-build uninstall did not
exist (#813).

/runtime/state now reports "present" for each runtime: installed, or its
app, download or kept-aside files on disk. Settings offers the inactive
runtime's uninstall whenever it is present, and the active one's when the
other is installed to switch to, as before. The backend already removed an
inactive runtime in any state.
@aaf2tbz
aaf2tbz force-pushed the fix/uninstall-runtime-rows branch from 4922546 to 6cb618a Compare November 20, 2026 17:20
…-rows

# Conflicts:
#	app-gpui/backend-route-inventory.json
@aaf2tbz
aaf2tbz merged commit ecb32cd into main Nov 20, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Options to delete FEX or X86 builds

1 participant