Repository navigation
fix(settings): offer Uninstall FEX / x86_64 for a runtime that is only downloaded - #815
Merged
Merged
Conversation
…y downloaded Settings > Advanced offered "Uninstall FEX" and "Uninstall x86_64" only when both runtimes were fully installed. A runtime that was downloaded but whose setup never finished (FEX's, in #811) left no way to remove its download but "Uninstall MetalSharp", so it looked as if the per-build uninstall did not exist (#813). /runtime/state now reports "present" for each runtime: installed, or its app, download or kept-aside files on disk. Settings offers the inactive runtime's uninstall whenever it is present, and the active one's when the other is installed to switch to, as before. The backend already removed an inactive runtime in any state.
aaf2tbz
force-pushed
the
fix/uninstall-runtime-rows
branch
from
November 20, 2026 17:20
4922546 to
6cb618a
Compare
…-rows # Conflicts: # app-gpui/backend-route-inventory.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #813. Settings > Advanced already has "Uninstall FEX" and "Uninstall x86_64", but they showed up only when both runtimes were fully installed. A runtime that was downloaded but never finished setup (the FEX runtime in #811) didn't count. That left "Uninstall MetalSharp" as the only way to remove its download, so it looked like no per-build uninstall existed.
Changes
wine_runtime.c: newms_wine_runtime_present(). It's true when the runtime is installed, or when its app inruntime/, its download indownloads/or its kept-aside files are on disk./runtime/statenow reports it aspresentfor each runtime.settings_preview.rs:present.presentfalls back toinstalled.runtime_routes_test.c: regression test. With only the inactive runtime's download on disk, it checks:/runtime/statereports that runtimeinstalled:false, present:truePR Readiness (MANDATORY)
/Users/...paths introducedTest notes
make -C app/src-c testnorpackage-app.shwas run. CI and a local run should cover this before merge.cargo check --testsofapp-gpuipasses on Linux. The macOS-only FFI was stubbed in a scratch copy for this, not in the branch.cargo fmt --checkis clean.clang -fsyntax-onlyreports no errors in the changed code; the only errors come from existing Darwin-only APIs.git clang-format --diffis clean.Generated by Claude Code