Repository navigation
build: ziz0 compiles with Chapel 2.10; wire just test; ascii-check can fail - #13
Merged
Merged
Conversation
…n fail ziz0.chpl had never been through a compiler. Mechanical fixes only: - identifiers that are Chapel keywords: out -> buf, by -> agent, index -> keyIndex; `for _ in` -> named loop var - x.car!/cdr!/body! yield a borrowed Value; add carV/cdrV/bodyV shared accessors; `try! x: V` for the two remaining unwraps - map inserts via add/addOrReplace (indexing a missing key throws) - concrete `enum P` (Add = 0) so prim ids cast; `in` intent on mkEnv All examples except layout.ziz (sexp reader only, by design) print what HANDOFF.adoc expects: 3628800, (sym:fact :arity 1) asserted=1 observed=11, (var y) (var z) (var q). lib/dialectic.ziz's defmacro expands. Justfile: build checks chpl is 2.10; new examples-check asserts the expected lines; test = grammar + examples-check + ascii-check (replacing the template's always-fail stub); ascii-check rewritten as a real lexer over .ziz files that fails on non-ASCII outside strings/comments (the old recipe always exited 0). Each check shown to fail on a planted fault. README tour corrected to the real JEG dump (25 judgements, 206 edges). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #12.
bootstrap/ziz0.chplhad never been through a compiler; it now builds with Chapel 2.10.0 and runs.ziz0 fixes (mechanical, no restructuring — per HANDOFF.adoc)
out→buf,by→agent,index→keyIndex;for _ in→ named loop varx.car!/cdr!/body!yield a borrowedValue; addedcarV/cdrV/bodyVshared accessors,try! x: Vfor the other two unwrapsmapinserts viaadd/addOrReplace(indexing a missing key throws in 2.x)enum P(Add = 0) so prim ids cast;inintent onmkEnvVerified
fact.ziz3628800,(sym:fact :arity 1) ; asserted=1 observed=11lambda.ziz(var y)(var z)(var q)— λ-calculus + Y smoke testquote-eval.ziz(+ 1 2 3)+615reflexive.ziz,hello.ziz84,hello, zizlib/dialectic.zizdefmacroexpands;(sublate 40 2)→42afterset-resolver!;:expanded-byedges recordedlayout.zizis not run: the off-side reader is milestone 1 by design.Justfile
buildcheckschplis 2.10 (chapel_version) and fails with install guidance otherwiseexamples-checkasserts the expected lines abovetest=grammar+examples-check+ascii-check(replaces the template's always-fail stub)ascii-checkrewritten: a small lexer over.zizfiles, fails on non-ASCII outside"strings"and;comments. The old recipe ended in|| trueand could never fail.Planted-fault controls, each confirmed to fail:
λas an identifier → ascii-check rc=1 (non-ASCII inside a string/comment passes); wrong expected value → examples-check rc=1; fakechpl 2.9.1→ build rc=1.just test→ rc=0.Docs: README status + tour corrected to the real JEG dump (25 judgements / 206 edges, not "6 / 23"); README §Building; TRIAGE/HANDOFF status.
Not in this PR
just testis local-only for now..deed: blocked, see the session report — the translator fails closed because ziz's descriptiles still carry the template identity.🤖 Generated with Claude Code