Skip to content

ci: drop secrets: inherit from the scanner; grant actions: read on the scorecard job #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperpolymath merged 1 commit into from
Oct 19, 2026
Merged

ci: drop secrets: inherit from the scanner; grant actions: read on the scorecard job #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/scorecard.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@ jobs:
# Reusable called-workflow permissions are CAPPED by the caller's grants;
# without security-events: write here the scorecard SARIF upload fails with
# startup_failure (hypatia WF018). id-token: write enables OIDC publish.
# actions: read must be repeated here: a job-level block replaces the
# workflow-level one, and the callee's job asks for actions: read.
permissions:
actions: read
contents: read
security-events: write
id-token: write
7 changes: 4 additions & 3 deletions .github/workflows/secret-scanner.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@
# Calls the estate's shared secret scanner (gitleaks + rust-secrets +
# shell-secrets).
#
# `secrets: inherit` is REQUIRED: without it the gitleaks action's inner
# secrets.GITHUB_TOKEN is empty and the scan silently degrades.
# No `secrets:` line: the reusable workflow (standards@75bd5994) declares no
# secrets and reads none. Its gitleaks is a pinned local binary, and the
# GITHUB_TOKEN its jobs run under is governed by `permissions:`, not by secret
# passing. `secrets: inherit` would forward every repository secret for nothing.
name: "Secret Scanner"
on:
push:
Expand All @@ -21,4 +23,3 @@ permissions:
jobs:
scan:
uses: hyperpolymath/standards/.github/workflows/secret-scanner-reusable.yml@75bd5994470661a099df562d6d5ad2fe744dbd66
secrets: inherit
Loading