Skip to content

fix: update customDictContentEnd after ZDICT_finalizeDictionary in COVER_selectDict #4769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VirajMishra1 wants to merge 1 commit into
base: dev
Choose a base branch
from
+4 −0
Open

fix: update customDictContentEnd after ZDICT_finalizeDictionary in COVER_selectDict #4769

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/dictBuilder/cover.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1075,6 +1075,10 @@ COVER_dictSelection_t COVER_selectDict(BYTE* customDictContent, size_t dictBuffe
free(candidateDictBuffer);
return COVER_dictSelectionError(dictContentSize);
}
/* Update customDictContentEnd to reflect the actual size after finalization.
* ZDICT_finalizeDictionary() may shrink dictContentSize by adding the header,
* so the pointer computed before the call would be stale. */
customDictContentEnd = customDictContent + dictContentSize;

totalCompressedSize = COVER_checkTotalCompressedSize(params, samplesSizes,
samplesBuffer, offsets,
Expand Down