Skip to content

Fix potential NULL pointer dereference in ZSTD_customCalloc when cust… - #4613

Merged
Cyan4973 merged 1 commit into
meta:devfrom
nidu-ninja:null-deref-custom-calloc
Mar 16, 2026
Merged

Cyan4973 merged 1 commit into
meta:devfrom
nidu-ninja:null-deref-custom-calloc

Conversation

@nidu-ninja

Copy link
Copy Markdown
Contributor

…om allocator fails

The fix introduces a NULL check immediately after the custom allocation call. If allocation fails, the function now safely returns NULL instead of dereferencing the pointer.

This improves the robustness of the memory allocation path and prevents possible crashes when using custom memory allocators.

@meta-cla

meta-cla Bot commented Mar 7, 2026

Copy link
Copy Markdown

Hi @nidu-ninja!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla Bot added the CLA Signed label Mar 7, 2026
@meta-cla

meta-cla Bot commented Mar 7, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@terrelln terrelln left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @nidu-ninja!

@Cyan4973
Cyan4973 merged commit e568656 into meta:dev Mar 16, 2026
105 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants