Repository navigation
Conversation
cortinico
marked this pull request as ready for review
October 30, 2026 19:26
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D128666153. |
javache
approved these changes
Nov 2, 2026
javache
left a comment
Member
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
@cortinico merged this pull request in 864b1a8. |
meta-codesync Bot
pushed a commit
that referenced
this pull request
Nov 4, 2026
Summary: - Add `./gradlew format` and `./gradlew formatCheck` for every Java source in SoLoader, using pinned Google Java Format 1.25.2 downloaded by Gradle. No formatter binary is committed. - Add a `format` GitHub Actions job that checks Java formatting. - Document the same commands for standalone and fbsource checkouts. Follow-up to #156. This PR is based on its branch so the diff contains only formatting setup; it can be retargeted to `main` after #156 merges. Pull Request resolved: #157 Test Plan: - `./gradlew format` — passed; the 66 existing Java files already conform to the pinned formatter. - `./gradlew formatCheck` — passed. - Temporarily introduced a formatting error in a Java file: `formatCheck` failed as expected, and `format` restored the file. No source-file changes remain. - `git diff --check` — passed. - [GitHub Actions](https://github.com/meta/SoLoader/actions/runs/41116915811) — both `format` and `build` jobs passed. ## Changelog - Internal: developer tooling only. Reviewed By: javache Differential Revision: D129603382 Pulled By: cortinico fbshipit-source-id: de76f240654f14db1d40912c1084d246eaa255cf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the obsolete GitHub Actions Buck job with a Gradle build of the SoLoader
Android AAR and the separate annotation and nativeloader JARs. Add Maven Local
publications for all three artifacts and check them in CI. Keep the Buck files
available, but do not run them in GitHub Actions. This does not publish to Maven
Central.
The publication version is read from the existing artifact configurations.
The Java 7 class-file target and the library manifest metadata preserve the
compatibility of the existing Maven artifacts.
Test plan
git -c core.whitespace=cr-at-eol diff --cached --checkpassed (the generated Windows wrapper uses CRLF)../gradlew publishToMavenLocalpassed locally on JDK 17 with JVM proxy settings, publishing to a temporary Maven Local repository.The new AAR does not preserve the obsolete
targetSdkVersion=23entry from theBuck-generated manifest: the Android Gradle Plugin omits library target SDKs.
Its
minSdkVersion=9and SoLoader application metadata are preserved. Thestale manifest
versionName=0.1.0andversionCode=1are intentionally omitted;the Maven publication version comes from the artifact configurations.