Skip to content

Build SoLoader with Gradle in GitHub Actions - #156

Closed
cortinico wants to merge 5 commits into
mainfrom
chore/remove-buck-github-actions
Closed

cortinico wants to merge 5 commits into
mainfrom
chore/remove-buck-github-actions

Conversation

@cortinico

@cortinico cortinico commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Replace the obsolete GitHub Actions Buck job with a Gradle build of the SoLoader
Android AAR and the separate annotation and nativeloader JARs. Add Maven Local
publications for all three artifacts and check them in CI. Keep the Buck files
available, but do not run them in GitHub Actions. This does not publish to Maven
Central.

The publication version is read from the existing artifact configurations.
The Java 7 class-file target and the library manifest metadata preserve the
compatibility of the existing Maven artifacts.

Test plan

  • git -c core.whitespace=cr-at-eol diff --cached --check passed (the generated Windows wrapper uses CRLF).
  • ./gradlew publishToMavenLocal passed locally on JDK 17 with JVM proxy settings, publishing to a temporary Maven Local repository.
  • Compared local 0.13.0 publications against Maven Central 0.12.1: AAR/JAR formats, three source and Javadoc JAR pairs, POM coordinates and dependency scopes, and Java 7 class-file versions match. Sources differ between the versions, so binary equality is not expected.
  • Maven Central does not have 0.13.1 (the version requested for comparison); the 0.13.1 POM returns 404.
  • CI passed with the Maven Local publishing step.

The new AAR does not preserve the obsolete targetSdkVersion=23 entry from the
Buck-generated manifest: the Android Gradle Plugin omits library target SDKs.
Its minSdkVersion=9 and SoLoader application metadata are preserved. The
stale manifest versionName=0.1.0 and versionCode=1 are intentionally omitted;
the Maven publication version comes from the artifact configurations.

@meta-cla meta-cla Bot added the CLA Signed label Oct 30, 2026
@cortinico cortinico changed the title Remove obsolete Buck GitHub Actions build Build SoLoader with Gradle in GitHub Actions Oct 30, 2026
@cortinico
cortinico marked this pull request as ready for review October 30, 2026 19:26
@meta-codesync

meta-codesync Bot commented Oct 30, 2026

Copy link
Copy Markdown

@cortinico has imported this pull request. If you are a Meta employee, you can view this in D128666153.

@javache javache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@meta-codesync meta-codesync Bot closed this in 864b1a8 Nov 2, 2026
@meta-codesync meta-codesync Bot added the Merged label Nov 2, 2026
@meta-codesync

meta-codesync Bot commented Nov 2, 2026

Copy link
Copy Markdown

@cortinico merged this pull request in 864b1a8.

meta-codesync Bot pushed a commit that referenced this pull request Nov 4, 2026
Summary:
- Add `./gradlew format` and `./gradlew formatCheck` for every Java source in SoLoader, using pinned Google Java Format 1.25.2 downloaded by Gradle. No formatter binary is committed.
- Add a `format` GitHub Actions job that checks Java formatting.
- Document the same commands for standalone and fbsource checkouts.

Follow-up to #156. This PR is based on its branch so the diff contains only formatting setup; it can be retargeted to `main` after #156 merges.

Pull Request resolved: #157

Test Plan:
- `./gradlew format` — passed; the 66 existing Java files already conform to the pinned formatter.
- `./gradlew formatCheck` — passed.
- Temporarily introduced a formatting error in a Java file: `formatCheck` failed as expected, and `format` restored the file. No source-file changes remain.
- `git diff --check` — passed.
- [GitHub Actions](https://github.com/meta/SoLoader/actions/runs/41116915811) — both `format` and `build` jobs passed.

## Changelog

- Internal: developer tooling only.

Reviewed By: javache

Differential Revision: D129603382

Pulled By: cortinico

fbshipit-source-id: de76f240654f14db1d40912c1084d246eaa255cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants