Skip to content

Preserve log scaling when merging choice parameters #5307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ltiao wants to merge 1 commit into from
Closed

Preserve log scaling when merging choice parameters #5307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions ax/adapter/transfer_learning/tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,36 @@


class AxFbCoreUtilsTest(TestCase):
def test_merge_choice_parameters_preserves_log_scale(self) -> None:
for log_scale, extra_value in [(True, 3), (False, 4)]:
choice = ChoiceParameter(
"x",
parameter_type=ParameterType.INT,
values=[1, 2],
is_ordered=True,
sort_values=True,
log_scale=log_scale,
)
other_choice = ChoiceParameter(
"x",
parameter_type=ParameterType.INT,
values=[2, extra_value],
is_ordered=True,
sort_values=True,
log_scale=not log_scale,
)
fixed = FixedParameter(
"x", parameter_type=ParameterType.INT, value=extra_value
)
for p1, p2 in [(choice, other_choice), (choice, fixed), (fixed, choice)]:
with self.subTest(log_scale=log_scale, p1=p1, p2=p2):
merged = assert_is_instance(
merge_parameters(p1, p2, reverse_param_config={}),
ChoiceParameter,
)
self.assertEqual(merged.values, [1, 2, extra_value])
self.assertEqual(merged.log_scale, log_scale)

def test_get_joint_search_space(self) -> None:
parameters: list[Parameter] = [
RangeParameter(f"x{i}", parameter_type=ParameterType.INT, lower=0, upper=5)
Expand Down
2 changes: 2 additions & 0 deletions ax/adapter/transfer_learning/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ def merge_parameters(
is_fidelity=choice_param.is_fidelity,
target_value=choice_param.target_value,
sort_values=choice_param.sort_values,
log_scale=choice_param.log_scale,
dependents=merge_dependents(
p1=p1,
p2=p2,
Expand All @@ -181,6 +182,7 @@ def merge_parameters(
is_fidelity=p1.is_fidelity,
target_value=p1.target_value,
sort_values=p1.sort_values,
log_scale=p1.log_scale,
dependents=merge_dependents(
p1=p1, p2=p2, reverse_param_config=reverse_param_config
),
Expand Down
Loading