Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@ltiao has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126124332. |
meta-codesync
Bot
changed the title
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Oct 19, 2026
Summary: # Why External generators need the same generation limits as other generation nodes. Their constructor currently cannot accept the existing pausing criteria. # Changes - Accept optional `pausing_criteria` and pass them to `GenerationNode`. Existing callers keep their current behavior. - Test that a configured trial limit blocks the next external candidate. # Examples ## Before ```python # In an ExternalGenerationNode subclass: super().__init__(name="external", pausing_criteria=[MaxTrialsAwaitingData(threshold=1, not_in_statuses=[])]) # TypeError: unexpected keyword argument 'pausing_criteria' ``` ## After ```python super().__init__(name="external", pausing_criteria=[MaxTrialsAwaitingData(threshold=1, not_in_statuses=[])]) # One trial can be generated and attached. The next request raises DataRequiredError. ``` Reviewed By: saitcakmak Differential Revision: D126124332
ltiao
force-pushed
the
export-D126124332
branch
from
October 19, 2026 20:03
0d8e273 to
c287a03
Compare
ltiao
added a commit
to ltiao/Ax
that referenced
this pull request
Oct 19, 2026
Summary: Pull Request resolved: meta#5303 # Why External generators need the same generation limits as other generation nodes. Their constructor currently cannot accept the existing pausing criteria. # Changes - Accept optional `pausing_criteria` and pass them to `GenerationNode`. Existing callers keep their current behavior. - Test that a configured trial limit blocks the next external candidate. # Examples ## Before ```python # In an ExternalGenerationNode subclass: super().__init__(name="external", pausing_criteria=[MaxTrialsAwaitingData(threshold=1, not_in_statuses=[])]) # TypeError: unexpected keyword argument 'pausing_criteria' ``` ## After ```python super().__init__(name="external", pausing_criteria=[MaxTrialsAwaitingData(threshold=1, not_in_statuses=[])]) # One trial can be generated and attached. The next request raises DataRequiredError. ``` Reviewed By: saitcakmak Differential Revision: D126124332
ltiao
force-pushed
the
export-D126124332
branch
from
October 19, 2026 20:07
c287a03 to
3740282
Compare
Summary: Pull Request resolved: meta#5303 # Why External generators need the same generation limits as other generation nodes. Their constructor currently cannot accept the existing pausing criteria. # Changes - Accept optional `pausing_criteria` and pass them to `GenerationNode`. Existing callers keep their current behavior. - Test that a configured trial limit blocks the next external candidate. # Examples ## Before ```python # In an ExternalGenerationNode subclass: super().__init__(name="external", pausing_criteria=[MaxTrialsAwaitingData(threshold=1, not_in_statuses=[])]) # TypeError: unexpected keyword argument 'pausing_criteria' ``` ## After ```python super().__init__(name="external", pausing_criteria=[MaxTrialsAwaitingData(threshold=1, not_in_statuses=[])]) # One trial can be generated and attached. The next request raises DataRequiredError. ``` Reviewed By: saitcakmak Differential Revision: D126124332
ltiao
force-pushed
the
export-D126124332
branch
from
October 19, 2026 20:12
3740282 to
01f5ea3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5303 +/- ##
=======================================
Coverage 96.59% 96.60%
=======================================
Files 621 621
Lines 71054 71064 +10
=======================================
+ Hits 68638 68651 +13
+ Misses 2416 2413 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in 80694ce. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Why
External generators need the same generation limits as other generation nodes. Their constructor currently cannot accept the existing pausing criteria.
Changes
pausing_criteriaand pass them toGenerationNode. Existing callers keep their current behavior.Examples
Before
After
Reviewed By: saitcakmak
Differential Revision: D126124332