Repository navigation
Preserve treatment SEMs for zero relative changes - #5302
Closed
saitcakmak wants to merge 1 commit into
Closed
saitcakmak wants to merge 1 commit into
saitcakmak wants to merge 1 commit into
Conversation
Summary: ## What Changed - Keep constant-control unrelativize SEMs on the rescaled treatment value, including zero relative means. - Identify the real status quo by arm name so a treatment with identical statistics is not mistaken for the control in constant-control mode. - Restore true status-quo (0, 0) observations inside BaseRelativize._get_rel_mean_sem, preserving subclass dispatch and TransformToNewSQ absolute-scale interpretation. - Restrict the raw-statistics identity shortcut to forward relativization, avoiding accidental equality between relative predictions and absolute controls during inverse transforms. - Clarify that the utility zero-relative-mean override applies only outside constant-control mode. Addresses review comments 1, 2, and 4. Nonconstant-control forward variance parity (comment 3) is isolated in a separate stacked change tracked by T293694908. Based on meta#5301. Differential Revision: D126108875
meta-cla
Bot
added
the
CLA Signed
|
@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126108875. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5302 +/- ##
==========================================
+ Coverage 96.59% 96.60% +0.01%
==========================================
Files 621 621
Lines 70966 71054 +88
==========================================
+ Hits 68550 68643 +93
+ Misses 2416 2411 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in 34f5ff6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
What Changed
Addresses review comments 1, 2, and 4. Nonconstant-control forward variance parity (comment 3) is isolated in a separate stacked change tracked by T293694908.
Based on #5301.
Differential Revision: D126108875