Skip to content

Fix when the GNUInstallDirs function include location - #220

Open
nullr0ute wants to merge 1 commit into
meta-pytorch:mainfrom
nullr0ute:GNUInstDir
Open

nullr0ute wants to merge 1 commit into
meta-pytorch:mainfrom
nullr0ute:GNUInstDir

Conversation

@nullr0ute

Copy link
Copy Markdown

The GNUInstallDirs must run before anything that references the CMAKE_INSTALL_INCLUDEDIR/ so should be included much earlier in the CMakeLists.txt otherwise those variable are otherwise empty at the point the generator capture them.

The GNUInstallDirs must run before anything that references the
CMAKE_INSTALL_INCLUDEDIR/ so should be included much earlier in
the CMakeLists.txt otherwise those variable are otherwise empty
at the point the generator capture them.

Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
@meta-cla

meta-cla Bot commented Oct 1, 2026

Copy link
Copy Markdown

Hi @nullr0ute!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant