add sol2 to wrapdb - #2766
add sol2 to wrapdb#2766v-for-vandal wants to merge 1 commit into
Conversation
|
Local sanity checks fails with this error, so I will debug via CI :( Also, meson setup builddir -Dwraps=sol2 totally ignores my provided meson.build and uses one from project, which is unfortunate :( |
|
Hi @dcbaker ! This PR is green :) Can I (or you) merge it ? Is there something that needs fixing ? |
bgilbert
left a comment
There was a problem hiding this comment.
Please rebase and squash your commits.
| 'sol2', | ||
| 'cpp', | ||
| license: 'MIT', | ||
| meson_version: '>=0.58', |
There was a problem hiding this comment.
Why is 0.58 required? CI thinks 0.56.0 is sufficient.
| "_comment": [ | ||
| "provided meson.build file is incompatible with WrapDB" | ||
| ], | ||
| "ignore_upstream_meson": "3.5.0" |
There was a problem hiding this comment.
This option is meant as a temporary measure, and not to allow us to carry a diverging Meson config forever. Could upstream's meson.build be updated to be compatible with WrapDB's Lua?
There was a problem hiding this comment.
I don't know. I doubt it can be done easily - the original meson is dependent upon lua.wrap that is 8 years old and is from this project: https://github.com/OrfeasZ/lua-meson. And it will require for me to go talk wth the author and try to talk him into changing something that works into something that potentially breaks some obscure side case or another for some of his users.
In short, I am not overly fond of this idea :)
0fc9dfe to
a668a08
Compare
a668a08 to
6c82b83
Compare
Add sol2 to wrapdb