Skip to content

add sol2 to wrapdb - #2766

Open
v-for-vandal wants to merge 1 commit into
mesonbuild:masterfrom
v-for-vandal:sol2-wrap
Open

v-for-vandal wants to merge 1 commit into
mesonbuild:masterfrom
v-for-vandal:sol2-wrap

Conversation

@v-for-vandal

Copy link
Copy Markdown
Contributor

Add sol2 to wrapdb

@v-for-vandal

v-for-vandal commented Apr 30, 2026 •

Copy link
Copy Markdown
Contributor Author

Local sanity checks fails with this error, so I will debug via CI :(

aserebriyskiy@i113824053:~/Dev/wrapdb$ ./tools/sanity_checks.py 
setUpClass (__main__.TestReleases) ... ERROR

======================================================================
ERROR: setUpClass (__main__.TestReleases)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/aserebriyskiy/Dev/wrapdb/./tools/sanity_checks.py", line 219, in setUpClass
    raise Exception("Missing Git tags; try 'git fetch --unshallow'")
Exception: Missing Git tags; try 'git fetch --unshallow'

----------------------------------------------------------------------
Ran 0 tests in 0.002s

FAILED (errors=1)

Also, meson setup builddir -Dwraps=sol2 totally ignores my provided meson.build and uses one from project, which is unfortunate :(

@v-for-vandal

Copy link
Copy Markdown
Contributor Author

Hi @dcbaker !

This PR is green :) Can I (or you) merge it ? Is there something that needs fixing ?

@bgilbert bgilbert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and squash your commits.

'sol2',
'cpp',
license: 'MIT',
meson_version: '>=0.58',

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is 0.58 required? CI thinks 0.56.0 is sufficient.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Comment thread ci_config.json
"_comment": [
"provided meson.build file is incompatible with WrapDB"
],
"ignore_upstream_meson": "3.5.0"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This option is meant as a temporary measure, and not to allow us to carry a diverging Meson config forever. Could upstream's meson.build be updated to be compatible with WrapDB's Lua?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. I doubt it can be done easily - the original meson is dependent upon lua.wrap that is 8 years old and is from this project: https://github.com/OrfeasZ/lua-meson. And it will require for me to go talk wth the author and try to talk him into changing something that works into something that potentially breaks some obscure side case or another for some of his users.
In short, I am not overly fond of this idea :)

@bgilbert bgilbert added the needs fixes Pull request received review feedback and needs adjustments label Aug 10, 2026
@github-actions github-actions Bot removed the needs fixes Pull request received review feedback and needs adjustments label Sep 28, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants