refactor: making trans usage explicit with kerLift - #1
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the proof of exists_integral_inj_algHom_of_quotient in Mathlib/RingTheory/NoetherNormalization.lean to make the “integrality passes to the kernel-lift” step explicit via RingHom.IsIntegral.kerLift, replacing a more manual comp-based rewrite. This improves clarity and supports downstream tooling (as noted in the PR description).
Changes:
- Replace an explicit
AlgHom.extproof of a composition identity with the reusable lemmaRingHom.IsIntegral.kerLift. - Simplify the final integrality composition step to
intg.trans ...using the derivedintgϕ.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slightly simplifies the argument used in
exists_integral_inj_algHom_of_quotientfor clarity.This is also needed to fix a small edge case present in a linter I am making as discussed here: #mathlib4 > Linter for ellipsis @ 💬