feat(server): 10 preset provider templates with one-click enable - #36
Merged
Merged
Conversation
added 2 commits
September 26, 2026 16:05
Adds the closed-set preset gallery (ticket 02 — 10 templates) on top
of the v2 providers-config surface from ticket 01.
New module:
- server/lib/provider-presets.js — 10 frozen template records
(zhipu, kimi, bailian, volcano, mimo, minimax, opencode-go,
openrouter, claude-code, codex). Each one round-trips through
normaliseProvider at module load so a schema regression
surfaces immediately. Templates NEVER carry key material —
publicPresetView strips auth.apiKey entirely. The
materialise helper clones a template into a v2-shaped provider
ready for writeProvidersConfig (enabled: true, preset tag,
empty apiKey).
New routes (Hono, OWNED_ROUTES):
- GET /api/providers/presets — gallery with enabled
flag + enabledIds.
- POST /api/providers/preset/:id/enable — one-click materialise
+ PUT (atomic write
+ same SSE broadcast).
Behaviour:
- enable is idempotent: a second call for an already-configured
id returns 200 with alreadyEnabled:true and the existing
(masked) record rather than clobbering user edits.
- id clash: a custom provider sharing a preset id is preserved
verbatim (idempotent branch).
- apiKey is never echoed in any response — masking is preserved
through publicView.
Protocol/auth mapping (also pinned by tests):
- zhipu / kimi / bailian / volcano / mimo / minimax /
openrouter: openai + byok
- opencode-go: openai + coding-plan
- claude-code: anthropic + coding-plan
- codex: openai + coding-plan
Tests:
- test/lib/provider-presets.test.js — 36 tests covering
catalogue shape, no-key invariant, protocol/auth mapping,
schema acceptance, lookup + materialise helpers,
publicPresetView shape.
- test/routes/provider-presets.check.mjs — 15 tests covering
GET gallery (enabled flag), POST enable (idempotency, id
clash, persistence, hot-reload, Hono-style params, masking
through SSE).
Documentation:
- docs/API.md — added endpoints with response shapes.
- package.json — updated the providers endpoints summary.
Verified:
- pnpm typecheck: clean
- pnpm test:webapp: 213/213 pass
- pnpm test:webui: 1406 pass, 7 pre-existing auth-gate
failures unrelated to this change (also fail on main before
this commit).
- pnpm build: clean (esbuild + next build).
- pnpm check:source + pnpm check:tsconfig + pnpm check:ci
(docs alignment): clean.
- live self-check on isolated 127.0.0.1:18100 with tmp data
dir: GET /api/providers/presets returns 10 with enabled
flags; POST /api/providers/preset/zhipu/enable materialises
the record (apiKey empty), persists to user-level file;
GET /api/providers reflects the new provider; GET /api/models
lists zhipu/glm-4-plus, glm-4-air, glm-4-flash with
protocol:openai, contextLimit:128000, modalities:[text];
idempotent re-enable returns alreadyEnabled:true; unknown id
returns 400 UNKNOWN_PRESET.
… auth.type
Ticket 02 acceptance follow-up.
Blocking:
- test/server/app-hono.test.js expected the OWNED_ROUTES ledger
to deep-equal a hard-coded list. Adding the preset routes
(GET /api/providers/presets, POST /api/providers/preset/:id/enable)
in commit bed10b5 widened the set without updating the test,
so the assertion failed on this branch even though the routes
were correctly wired in server/app.js. Add the two entries
to the expected list (mechanical, mirrors the app.js edit).
Non-blocking (documentation per acceptance):
- auth.type: 'coding-plan' on Claude Code / Codex / opencode go
is COSMETIC at this layer. No code path branches on it; the
enable handler materialises an empty-key record consumed
identically to a byok record. The label is preserved on the
persisted record as a stable placeholder for future
subscription-auth behaviour (per-provider key flow,
auto-refresh, scoped quotas). Documented in:
- server/lib/provider-presets.js (header comment)
- docs/API.md (GET /api/providers/presets section)
fengzhi09
added a commit
that referenced
this pull request
Sep 26, 2026
…h preset routes) PR #36 added preset provider templates alongside the existing provider routes, conflicting with this branch's edits to packages/webui/server/routes/providers.js (the keep-existing-key convention in handlePutProviders). Resolution: - routes/providers.js imports: union of both sides. The keep-key helpers (applyKeepKeyConvention, loadUserLevelProviders) from this branch plus normaliseProvider (used by handleEnablePreset) from main are all imported from lib/providers-config.js. - The new handleGetPresets / handleEnablePreset handlers from main coexist with this branch's handlePutProviders / handleTestProvider intact — both sides' logic survives. - routes/providers.js exports: re-export the preset handlers from this single module so the Hono app can mount them. Gates (post-merge): - app-hono.test.js: OWNED_ROUTES includes both sides; app.get / app.put / app.post calls for /api/providers, /api/providers/test, /api/providers/presets, /api/providers/preset/:id/enable all present (auto-merged clean). - providers-config + providers.check: 74 pass / 0 fail × 3. - app-hono: 85 pass / 0 fail. - full pnpm test:webapp: 253 pass / 0 fail. - full pnpm test: 1545 pass / 0 fail / 2 skipped (no regressions). - pnpm webapp:typecheck + pnpm typecheck: clean. - node scripts/source-inventory.mjs: clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ticket 02 of the provider-configuration feature: the preset provider gallery.
lib/provider-presets.js): 智谱, Kimi, 百炼, 火山, mimo, minimax, opencode go, OpenRouter, Claude Code, Codex — each with protocol (openai|anthropic|gemini), default baseURL, auth shape (byok | coding-plan), and a deliberately conservative model list (label/contextLimit/thinkingLevels/modalities only where publicly certain — sparse beats wrong).GET /api/providers/presets— gallery with enablement status, zero key material.POST /api/providers/preset/:id/enable— one-click materialise into the user-level config (enabled, preset tag, empty key, template models), hot-applied via the ticket-01 machinery; idempotent (alreadyEnabled), custom-id clash returns the existing record (no clobber), unknown id → 400.Acceptance (independent agent, 2 rounds)
Round 1 FAIL — route-parity contract test red: the branch widened app.js OWNED_ROUTES without updating app-hono.test.js's expected list (the dev's "7 pre-existing failures" claim was refuted against a clean main clone; the real flake root cause — PORT env leaking between suites — is now filed as a hygiene ticket). Round 2 PASS after the mechanical fix + honest docs: gallery/live-enable/idempotency/clash handling all verified;
auth.type: coding-planexplicitly documented as a cosmetic schema placeholder (no code branches on it; engine consumes both shapes through the same key path).Gates: typecheck 0 · focused suites 62/62 · full test:webui 1530 pass / 0 fail · test:webapp 213/213 · build ✓ · check:source ✓ (4582 files).
Full
pnpm verifydeferred to CI.