Derive feed mapping; add startup preflight - #19
Merged
Conversation
Delete feed_instrument — it was a persisted cache of a pure function. candidates() + to_feed_symbol() fully determine it, so derive the subscription set at subscribe time instead. Removes two failure modes (stale rows, non-retroactive) rather than managing them, and drops the map-feed step and its ordering rule. Add preflight: refuse to boot on an empty catalog/FK targets; log loud (but boot) when a held position cannot be priced or routed. Make sync-broker exit non-zero on FK skips unless --allow-skips. Stop logging the DB password on boot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete
feed_instrument— it was a persisted cache of a pure function.candidates()+to_feed_symbol()fully determine it, so the subscription set is derived at subscribe time instead of stored.This removes two failure modes rather than managing them:
sync-brokerhad no mapping until someone re-ranmap-feedmap-feed(subcommand,maketarget, seed step) and the seeding-order rule go with it.