Repository navigation
Conversation
* Initial plan * Add dynamic version from git tags via Makefile and Docker build args - Create Makefile that reads git tag version via `git describe` - Pass APP_VERSION as Docker build arg through docker-compose.yml - Update all Dockerfiles to accept APP_VERSION build arg and set as env var - Read APP_VERSION env var in web service instead of hard-coded config value - Log app version at web service boot - Fall back to config.json version if env var not set Agent-Logs-Url: https://github.com/maxi07/ScanSync/sessions/1ae7444f-19ab-4386-b174-a6292ff5885d Co-authored-by: maxi07 <7480270+maxi07@users.noreply.github.com> * Fix review comments: APP_VERSION override, fallback logic, smb/test service build args --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: maxi07 <7480270+maxi07@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial plan
Add dynamic version from git tags via Makefile and Docker build args
git describeAgent-Logs-Url: https://github.com/maxi07/ScanSync/sessions/1ae7444f-19ab-4386-b174-a6292ff5885d