Document WidgetDetailEvent setCacheTimeout() removal in Mautic 8 - #618
Open
promptless-for-oss wants to merge 1 commit into
Open
Conversation
…oval in Mautic 8 Source: mautic/mautic#17034 - removes the dead $cacheTimeout property and public setCacheTimeout() method from WidgetDetailEvent. Adds a short 'WidgetDetailEvent changes in Mautic 8' section to docs/plugins/cache.rst telling subscribers to remove any setCacheTimeout() call; behavior is unchanged (cache lifetime comes from Widget::getCacheTimeout()).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open in Promptless
Mautic 8 removes the
setCacheTimeout()method and its backing$cacheTimeoutstate from the dispatchedMautic\DashboardBundle\Event\WidgetDetailEvent. This adds a short "WidgetDetailEvent changes in Mautic 8" section to the Plugins Cache page so Plugin developers who subscribe to the Dashboard Widget events know to remove anysetCacheTimeout()call from their subscriber. The removed state was write-only dead code, so there's no behavior change — the Widget cache lifetime still comes fromWidget::getCacheTimeout()insetTemplateData(), and Widget data is cached only throughCacheProviderTagAwareInterface.Files touched:
docs/plugins/cache.rst(+11).Trigger Events