Remove deprecated formType from Forms API test - #350
Merged
Conversation
TomasVotruba
marked this pull request as ready for review
August 14, 2026 12:55
patrykgruszka
approved these changes
Aug 14, 2026
patrykgruszka
left a comment
Member
There was a problem hiding this comment.
The change is correct 👍
I think we'll need to figure use the branching model and supported Mautic versions in this repo.
escopecz
approved these changes
Aug 14, 2026
escopecz
left a comment
Member
There was a problem hiding this comment.
This is updating just the test which will fail on Mautic 8+. No production change was made. The code will still work for all Mautic versions. The new ones will just reject the outdated payloads. So I see no problem in merging this right away. Some version strategy would be good to have though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Companion to mautic/mautic#17082, which removes the long-deprecated form type from
Mautic\FormBundle\Entity\Form(deprecated since 7.1, removed in 8.0).Once core drops the field,
form:readresponses no longer includeformType.FormsTeststill sent it in the payload and asserted it back, so it fails against 8.0:This drops
formTypefrom both test payloads.Compatibility
Safe against older Mautic too:
formTypewas already ignored on write (allow_extra_fields => true).'name' => 'test', - 'formType' => 'standalone', 'description' => 'API test',