chore: upgrade first-party actions to node24 majors - #9
Open
mattpartida wants to merge 2 commits into
Open
mattpartida wants to merge 2 commits into
mattpartida wants to merge 2 commits into
Conversation
- actions/checkout@v4 -> v7 and actions/setup-python@v5 -> v7 in the CI workflow and both examples/ci/github-actions/ downstream examples so runs no longer use the deprecated node20 runtime - add tests/test_ci_actions_versions.py guarding runnable workflows against stale node20-era action majors and undocumented actions - document the node24 action runtime guidance in docs/ci-integration.md - add a changelog entry; no scanner behavior changes
7 tasks done
Resolve CHANGELOG conflict and extend node24 action majors (actions/checkout@v7, actions/setup-python@v7) to the newer agent-security-compare-reports.yml and agent-security-prompt-sarif.yml examples added to main after this branch was opened.
Owner
Author
|
Refreshed this PR against latest
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the GitHub Actions Node 24 deprecation warning (backlog item 8). All first-party actions in this repo ran on the deprecated node20 runtime:
actions/checkout@v4andactions/setup-python@v5in the CI workflow and bothexamples/ci/github-actions/copyable downstream examples.What changed
.github/workflows/ci.yml—actions/checkout@v4→@v7,actions/setup-python@v5→@v7(both v7 majors run on node24; verified viaaction.ymlusing: node24on the release tags).examples/ci/github-actions/agent-security-strict.ymlandagent-security-sarif.yml— same upgrades so copied downstream workflows don't inherit node20 deprecation warnings.tests/test_ci_actions_versions.py(new) — guards that runnable workflows only use allow-listed first-party actions at node24-compatible majors, and that stale node20-era refs (checkout@v1–v4,setup-python@v1–v5) never reappear; also checks the changelog/docs stay in sync.docs/ci-integration.md— new "Action runtime versions" section explaining the node24 guidance for downstream users.CHANGELOG.md— documentation-only-updates entry (CI tooling only; no scanner behavior change).Safety notes
actions/setup-python@v7removed the unusedpip-installinput; this repo's workflows don't use it (they usepython-versiononly), so no breakage.actions/checkout@v7is ESM-based with security fixes (blocks fork-PR checkout forpull_request_target/workflow_run); no inputs used here changed.github/codeql-action/upload-sarif@v4is already the latest major and left untouched.examples/schema-adapters/github-actions-*.jsonfixtures are scanner inputs, not runnable workflows — left unchanged deliberately.Test Plan
Local verification (Python 3.11.15, matching CI):
python -m compileall -q skills tests— OKpython -m pytest -q— 92 passed (89 prior + 3 new, TDD: confirmed red before the upgrade, green after)ruff check .— All checks passed./package-skills.sh— packaged both skillsgit diff --check— cleanactions/checkout@v7/setup-python@v7steps end to end