Skip to content

Employee detail rail shows manager as raw ID instead of resolved name #150

Closed

Description

@matthewod11-stack

Description

The employee detail panel's Details section renders the manager as ID: <manager_id> (e.g. ID: fixture-emp-priya) instead of the manager's resolved full name, even when the manager exists in the loaded employee list. Observed 2026-07-14 during People Map T10 verification with dev fixtures.

Current State

EmployeeDetail.tsx passes managerName={manager?.full_name} to DetailsSection; the fallback renders the raw ID. The manager lookup evidently misses even when the manager row exists (fixture-emp-priya was present and active). Likely the lookup searches a filtered/paginated list rather than fetching by ID.

Suggested Fix

  • Trace how manager is resolved in EmployeeDetail.tsx (list lookup vs get_employee fetch)
  • Resolve by ID via the backend command when not present in the loaded list
  • Fall back to the raw ID only when the reference is genuinely dangling (mirror the backend's skip-not-fatal behavior in people_map/context.rs)

Verification

  • npm test passes (add a case: manager resolved when not in the visible list)
  • npx tsc --noEmit clean
  • Dev app: fixture-emp-maya shows "Priya Raman" as manager, not the ID

Automation Hints

scope: src/components/employees/
do-not-touch: src-tauri/
approach: refactor-types
risk: low
max-files-changed: 4
blocked-by: none
bail-if: manager resolution requires a new Tauri command signature change

Priority

Low

Activity

  1. matthewod11-stack commented on Jul 15, 2026

    @matthewod11-stack
    OwnerAuthor

    Orchestrator opened PR: #153 (nightly run 2026-07-15). Left open for review — not auto-merge-eligible (approach refactor-types is outside the auto_merge safe_approaches set).

  2. added a commit that references this issue on Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    tech-debtEligible for automated overnight fixing

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions