Skip to content

fix(parser): parse short model ids without date suffix #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
axisrow wants to merge 1 commit into from
Closed

fix(parser): parse short model ids without date suffix #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/shared/utils/modelParser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ const KNOWN_FAMILIES: KnownModelFamily[] = ['sonnet', 'opus', 'haiku'];
*
* Supported formats:
* - New format: claude-{family}-{major}-{minor}-{date} (e.g., "claude-sonnet-4-5-20250929")
* - New format short: claude-{family}-{major} (e.g., "claude-sonnet-5")
* - Old format: claude-{major}-{family}-{date} (e.g., "claude-3-opus-20240229")
* - Old format with minor: claude-{major}-{minor}-{family}-{date} (e.g., "claude-3-5-sonnet-20241022")
*/
Expand Down Expand Up @@ -87,12 +88,9 @@ export function parseModelString(model: string | undefined): ModelInfo | null {

// Determine format based on family position
if (familyIndex === 1) {
// New format: claude-{family}-{major}-{minor}-{date}
// New format: claude-{family}-{major}[-{minor}][-{date}]
// e.g., claude-sonnet-4-5-20250929 -> ["claude", "sonnet", "4", "5", "20250929"]
if (parts.length < 4) {
return null;
}

// e.g., claude-sonnet-5 -> ["claude", "sonnet", "5"]
majorVersion = parseInt(parts[2], 10);
if (isNaN(majorVersion)) {
return null;
Expand Down
14 changes: 14 additions & 0 deletions test/shared/utils/modelParser.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,20 @@ describe('modelParser', () => {
});
});

it('should parse short format without minor or date: claude-sonnet-5', () => {
const result = parseModelString('claude-sonnet-5');
expect(result).toEqual({
name: 'sonnet5',
family: 'sonnet',
majorVersion: 5,
minorVersion: null,
});
});

it('should return null for invalid short format with non-numeric version', () => {
expect(parseModelString('claude-sonnet-x')).toBeNull();
});

it('should return null for invalid format with only two parts', () => {
expect(parseModelString('claude-sonnet')).toBeNull();
});
Expand Down