Repository navigation
fix(embedding): preserve retained casts and protect destructive MO inputs - #30
Merged
aunjgr merged 6 commits intoOct 11, 2026
Conversation
aunjgr
marked this pull request as ready for review
October 10, 2026 20:06
aunjgr
changed the title
This was referenced Oct 11, 2026
mergify Bot
pushed a commit
to matrixorigin/matrixone
that referenced
this pull request
Oct 12, 2026
The Go runner executes canonical Q1–Q22 over immutable SF1/SF10 inputs, fully drains public results and compares exact typed schema, values, duplicates and ordering against independently executed native MatrixOne. The controller owns separate LOG/TN/CN processes, bounded private spools and joined failure cleanup. All 744 timing executions are unprofiled. A separate 264-execution campaign captures actual CUDA allocation/free events. Logical credits/pool tags, physical allocations, residency, RSS and Go heap retain their source and scope. Shared CTE occurrences use independent destructive MO readers on the same statement snapshot. Merged [Sirius #30](matrixorigin/sirius#30) preserves retained VARCHAR identity casts and rejects reused/unreachable MO bindings. D pins merged native `955b6881`, preserves ABI v1 and uses the verified release SDK. Optional unprovisioned Flight profiles are N/A. Early consumer and provisioning failures cancel the unread query before driver close and preserve error ownership. Deterministic fixtures prove one physical connection, immutable SQL/config admission, complete-spool publication, late errors, failed-query cleanup, eight source identities and typed loaded row multisets. Frontend tests check actual query/account/physical-OID evidence and heading privacy. No dependency or CI-policy changes are introduced. Approved by: @XuPeng-SH
zuyu
pushed a commit
that referenced
this pull request
Oct 14, 2026
…puts (#30) * fix(embedding): preserve VARCHAR identity casts in exact plans * test(embedding): select explicit evaluator strategies * test(embedding): assert independent string offset ownership * style: format VARCHAR identity cast regression * test(expression): guard appended exact coefficient ABI slot * fix(embedding): reject replayed and unreachable destructive MO inputs
zuyu
pushed a commit
that referenced
this pull request
Oct 21, 2026
…puts (#30) * fix(embedding): preserve VARCHAR identity casts in exact plans * test(embedding): select explicit evaluator strategies * test(embedding): assert independent string offset ownership * style: format VARCHAR identity cast regression * test(expression): guard appended exact coefficient ABI slot * fix(embedding): reject replayed and unreachable destructive MO inputs
zuyu
pushed a commit
that referenced
this pull request
Oct 22, 2026
…puts (#30) * fix(embedding): preserve VARCHAR identity casts in exact plans * test(embedding): select explicit evaluator strategies * test(embedding): assert independent string offset ownership * style: format VARCHAR identity cast regression * test(expression): guard appended exact coefficient ABI slot * fix(embedding): reject replayed and unreachable destructive MO inputs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public MatrixOne TPC-H execution exposed two GPU correctness failures: Q7 failed on a retained VARCHAR identity cast, and Q15 could silently split a destructive MO input between consumers of a shared CTE.
Exact Substrait preparation skips DuckDB's ordinary optimizer and retains semantic
VARCHAR → VARCHARcasts. Preserve string values and validity by transferring an owned column or copying a borrowed view on the caller's stream and memory resource, instead of passing STRING to cuDF's fixed-width cast.Validate reachable read consumption through
ReferenceRelbefore admitting work. Shared references cannot replay a destructive MO input, and unreachable MO bindings cannot start producers that never receive a consumer. A single reference and immutable TAE replay remain valid. Reference expansion has explicit node/depth bounds. MatrixOne's accompanying fix gives each inlined MO occurrence an independent reader on the same snapshot; canonical SQL stays unchanged.Update the value-variant test to guard the already merged, appended exact coefficient at index 21. Its stale 21-alternative assertion prevented the owning test target from compiling. No native API or numeric ABI layout change.
Validation:
Prerequisite for MatrixOne #28968. Base:
upstream-dev-merge.