Skip to content

fix(openclaw): reject malformed health responses #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loveRhythm1990 merged 1 commit into from
Oct 21, 2026
Merged

fix(openclaw): reject malformed health responses #348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions plugins/openclaw/openclaw/__tests__/http-client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,16 @@ describe("Group 3: Cloud API Communication", () => {
expect(result.instance_id).toBe("i-1");
});

it.each([
["an object without status", { instance_id: "i-1", db: true }],
["an empty status", { status: " ", instance_id: "i-1", db: true }],
["a non-object response", "ok"],
])("3.29a healthCheck rejects %s", async (_description, response) => {
fetchMock.respondWith(200, response);

await expect(transport.healthCheck()).rejects.toThrow(/invalid health response/i);
});

it("3.30 unknown tool throws", async () => {
await expect(transport.callTool("memory_nonexistent", {}))
.rejects.toThrow(/Unknown Memoria tool/);
Expand Down
6 changes: 5 additions & 1 deletion plugins/openclaw/openclaw/http-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,8 +332,12 @@ export class MemoriaHttpTransport {
async healthCheck(): Promise<{ status: string; instance_id?: string; db?: boolean }> {
const data = await this.get("/health/instance");
const rec = this.asRecord(data);
const status = typeof rec?.status === "string" ? rec.status.trim() : "";
if (!status) {
throw new Error("Invalid health response: missing status");
}
return {
status: typeof rec?.status === "string" ? rec.status : "ok",
status,
instance_id: typeof rec?.instance_id === "string" ? rec.instance_id : undefined,
db: typeof rec?.db === "boolean" ? rec.db : undefined,
};
Expand Down
Loading