Repository navigation
Conversation
XuPeng-SH
left a comment
There was a problem hiding this comment.
Requesting changes for one evidence-contract gap in the workspace case. The incomplete-capture diagnostic change and the existing causal-success checks otherwise look consistent with their current owners. The gap below predates this PR, but this PR explicitly tightens the case prompt and adds a case-specific regression test, so the case can still report a false pass for the behavior it is meant to certify.
XuPeng-SH
left a comment
There was a problem hiding this comment.
I withdraw my previous requested change. The existing case is a smoke test for causal child workspace execution and the final answer; this PR clarifies its prompt and preserves that existing acceptance contract. Requiring a new file/range-to-child-call evidence join as a merge blocker would extend the scope and add complexity beyond this change. The current checks do not prove strict answer provenance, so the pass should be interpreted within that limit. The incomplete-capture diagnostic uses the existing integrity owner, and the added tests cover the relevant causal and unhappy paths. CI and the live regression passed on this head.
🚫 Left the queue1 min in the queue, with no time running CI. So far
Reason Pull request #1154 has been merged manually at 6b8f370 Hint You were too fast! Tick the box to put this pull request back in the merge queue (same as
Times in UTC · dashboard · how the merge queue works |
a79ec69 to
d5571f5
Compare
Capability assessment: Unchanged: this change tightens existing harness evidence checks without changing runtime capabilities or authority.
Summary
The workspace-evidence case now supplies an explicit read range covering the target section and asks for the literal edition without giving the expected value. Its existing causal-child criterion already requires exactly one successful child read. New regression coverage verifies that failed, unknown, unlinked and same-run reads cannot satisfy it. Delegation and final-answer checks remain unchanged.
Tool-count progress diagnostics now leave the count unknown for incomplete or corrupt captures, matching the grader’s existing fail-closed behavior instead of displaying a misleading zero.
Related issue
Follow-up to #1139. That PR merged at
b5799a3ewhile this final test-only supplement was being pushed; this supplement was not included in its merge. This branch starts from current main0fe324c6.Change type
User and compatibility impact
No product, authentication, database or deployment changes. Existing diagnostic schema and unknown-value representation are preserved. No timeout, retry or acceptance criterion is relaxed.
Architecture and complexity delta
The existing
SessionCaptureintegrity metadata and shared tool-outcome counter remain canonical. No parallel counter or evidence projection is introduced. Existing grader and progress consumers were reviewed.Verification
a79ec693: all 641 harness library tests passed, with 1 existing ignored test, including progress, case contracts and the new causal-child read regression. The first exact-name Cargo filter selected zero tests; it is not counted as validation. The subsequent full library test executable ran all 642 tests (641 passed, 1 ignored) with serial execution.cargo clippy -p astra-test-harness --lib --tests -- -D warnings, formatting and diff checks passed.a79ec693passed 3/3, with all original criteria passing: https://github.com/matrixorigin/Astra/actions/runs/40639899672 . The artifact confirms the exact source SHA. Full automatic PR CI remains pending; three repetitions do not prove that every historical intermittent failure is eliminated.Final checklist