Skip to content

[WIP] Add support for auto switch URL. - #76

Open
gucong3000 wants to merge 1 commit into
matheuss:masterfrom
gucong3000:auto_switch_url
Open

[WIP] Add support for auto switch URL.#76
gucong3000 wants to merge 1 commit into
matheuss:masterfrom
gucong3000:auto_switch_url

Conversation

@gucong3000

@gucong3000 gucong3000 commented Aug 22, 2018

Copy link
Copy Markdown

Closes #60

@codecov-io

codecov-io commented Aug 22, 2018

Copy link
Copy Markdown

Codecov Report

Merging #76 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   92.42%   92.42%           
=======================================
  Files           2        2           
  Lines          66       66           
=======================================
  Hits           61       61           
  Misses          5        5
Impacted Files Coverage Δ
index.js 90.19% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 777d7db...06103bd. Read the comment docs.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+1.5%) to 92.424% when pulling 06103bd on gucong3000:auto_switch_url into 777d7db on matheuss:master.

@rawr51919 rawr51919 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There shouldn't be anything breaking this API when this code is allowed, and from the looks of this code, it'll help greatly. I approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants