Use JSON.parse instead of safeEval - #71
Open
Adam-Clrk wants to merge 1 commit into
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
=========================================
- Coverage 92.42% 92.3% -0.12%
=========================================
Files 2 2
Lines 66 65 -1
=========================================
- Hits 61 60 -1
Misses 5 5
Continue to review full report at Codecov.
|
alexis89x
approved these changes
Jul 19, 2018
alexis89x
left a comment
alexis89x
left a comment
There was a problem hiding this comment.
Jumped to the same conclusion after being warned bu GitHub that SafeEval is not secure.
gucong3000
approved these changes
Aug 22, 2018
Norway174
approved these changes
Sep 3, 2018
Norway174
left a comment
Norway174
left a comment
There was a problem hiding this comment.
Tested it. And it works! Please approve of this.
gucong3000
approved these changes
Sep 10, 2018
wadie
approved these changes
Sep 24, 2018
wadie
approved these changes
Sep 25, 2018
wadie
left a comment
wadie
left a comment
There was a problem hiding this comment.
Maybe someone should create a fork of this and keep it updated ?
dennismuench
approved these changes
Nov 11, 2018
dennismuench
approved these changes
Nov 11, 2018
gucong3000
approved these changes
Nov 19, 2018
remzh
approved these changes
Feb 13, 2019
wadie
approved these changes
Feb 13, 2019
Done in vitalets#2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use of safeEval is considered a vulnerability
https://nodesecurity.io/advisories/337