[pull] release/3.0.0-beta2 from isaac-sim:release/3.0.0-beta2 - #32
Merged
pull[bot] merged 1 commit intoAug 26, 2026
Merged
Conversation
…7332) Currently `Build Base Docker Image` and `Build cuRobo Docker Image` fail with `denied: Access Denied` while resolving the Isaac Sim base image from public ("nvidia") NGC org. **Cause.** `ecr-build-push-pull` copies the runner's persistent `nvcr.io` credentials for a private NGC org into the job. NGC declines that identity a pull token for the public `nvidia/*` catalog, so an image that needs no credentials becomes unpullable. **Fix.** The setup step now confirms those credentials can read the configured base image, and retries anonymously when they cannot. The deps-hash step fails loudly on an unreadable digest, which until now corrupted the cache key in silence. `docker-build` receives the same fallback, and its login moves to `--password-stdin`. **Why this branch.** Only `release/3.0.0-beta2` pins a public base image, so the bug lives here alone. `develop` keeps this logic in `.github/actions/_lib/`, a path this branch does not have, so a fix there could never run here. | Before | After | | ------ | ----- | | Base image pull uses only the runner's inherited private-org credentials, which NGC refuses for the public catalog, so the job fails with `denied: Access Denied` | Credentials are tried first; if the registry refuses them the pull retries anonymously, and the public base image resolves | ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Release backport - [ ] <!-- backport-active-release --> Backport this pull request to the active release branch after it merges into `develop` (not applicable: this targets a release branch directly, and the equivalent code on `develop` is already correct) ## Screenshots Not applicable; the change affects CI credential handling only. ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [ ] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` (not run locally, no dev setup on this machine; this PR's own `pre-commit` check passes) - [ ] I have made corresponding changes to the documentation (no documented interface changes) - [ ] My changes generate no new warnings (not assessable for a composite action) - [ ] I have added tests that prove my fix is effective or that my feature works (no harness executes composite actions; the CI run on this PR is the check) - [ ] I have added a changelog fragment under `source/<pkg>/changelog.d/` for every touched package (do **not** edit `CHANGELOG.rst` or bump `extension.toml` — CI handles that) (no package under `source/` touched) - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )