DP-48482: Update PHP to 8.4 - #3482
Conversation
Composer package changesProd Packages (42 packages)
Dev Packages (5 packages)
|
…Formstack embed due to Symfony update
| services: | ||
| drupal: | ||
| image: "wodby/php:8.3-dev-4.54.1" | ||
| image: "wodby/php:8-4.70.7" |
There was a problem hiding this comment.
@tfleming-ma please pin to 8.4 here. Right now it allow ant 8.x version. 4.70.7 is wodby version of their container, and it can be the same for 8.3, 8.4
Blocker: the Rabbit Hole 1.x → 2.x upgrade drops every per-node overrideAfter deploying this branch, Person pages that are published through a per-node Rabbit Hole override start returning 404. In my sanitized copy that is 367 published WhyRabbit Hole 2.x reads the per-entity override only from the new That field is created by Nothing errors and The issueMust be 200, because has overrides:
But, locally on
No override — 404 on prod and local on the on The fix
What the fix needsTwo things, and exporting the config alone is not enough — I tried that first and the field comes back empty (0 rows), because
With both in place the branch matches the develop baseline exactly: the override pages are 200 again, the others stay 404, and Both are in #3493, which targets this branch. With them applied the branch matches the develop baseline exactly. |
This reverts commit 7c9f608.
…d, removed merge artifact
|
Re-reviewed after the rabbit_hole revert. The 404 blocker is gone (rabbit_hole back to 1.1.0, configs identical to develop, only the nullable patch remains). Three things left before merge, the first is a one-line fix. 1. 2. Same file still carries two keys that no longer exist in windows_aad beta10: 3. Also: the changelog only says "Bumped to PHP 8.4", but the PR carries two major prerelease upgrades (flag 5.1.0-beta2, reference_blocked_users 2.0.0-rc1), openid_connect alpha8 which now owns Everything else checked out: all seven php84 patches are purely mechanical, dropping |
Description:
Updated to PHP 8.4
Jira: (Skip unless you are MA staff)
DP-48482
To Test:
Peer Review Checklist