You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Upgrades massdriver-sdk-go from v0.2.14 → v0.2.17, which fixes two issues surfaced by agent sessions.
1. list_resource_grants was unusable on any resource with a scoped grant
Listing grants on any resource carrying a scoped grant failed to decode:
PolicyConditions[md-environment]: json: cannot unmarshal string into Go value of type []string
The platform's grant read path serializes a single-valued condition as a bare
scalar string ({"md-environment":"s3demo-demo"}), but the SDK's PolicyConditions.UnmarshalJSON only accepted "*" or a JSON array — so the entire
grant page failed to unmarshal, and there was no way to enumerate grants before
creating one. Fixed in the SDK (UnmarshalJSON now promotes a bare scalar to a
single-element set; "*" still maps to the wildcard). This repo just picks up the
fix via the dependency bump — the decode happens inside Instances/Resources
before the tool sees anything, so there's no in-repo code to change.
2. get_instance now returns incoming dependencies
Agents couldn't see what was wired into an instance. The SDK's instances.Get now
populates Instance.Dependencies (the filled connection slots — the upstream
resources feeding the instance). Because the handler serializes the full Instance,
this flows through automatically; the change here is to document it on the tool so
callers know to look, plus a test asserting dependencies serialize.
Review .github/workflows/docker-build.yaml and .goreleaser.yaml changes
Post final review
Summary: Small, low-risk PR. The SDK bump + doc/test changes for get_instance are correct and well-scoped. CI is green (Lint, Test, Docker build all passed).
Findings:
Unrelated changes not mentioned in the PR description (.github/workflows/docker-build.yaml:26, .goreleaser.yaml:17-19) — the PR body only describes the SDK bump, the get_instance description update, and the dependencies test, but the diff also adds linux/arm64 to the Docker build matrix and removes the windows/arm64 ignore rule from goreleaser. These look like intentional infra changes (probably related to the arm64 SDK build), but since they're undocumented in the PR description, worth a sentence explaining why they're bundled here — makes the history easier to follow later. Not a blocker.
mcp/tools/instances.go:52-54 — description update is accurate and clear; correctly notes dependencies reflects incoming connections, matching what instances.Get now populates per the SDK bump.
mcp/tools/instances_test.go:134-153 — good coverage: asserts "dependencies" serializes into the JSON result via a populated types.InstanceDependency. Straightforward and matches the existing test style in the file (stub-based, table-driven).
go.sum — the three new massdriver-sdk-go entries (v0.2.15, v0.2.16, v0.2.17) alongside the existing v0.2.14 entry look correct for MVS resolution; go.mod correctly pins to v0.2.17 only.
No functional bugs found. The core fix (scoped-grant unmarshal) lives entirely in the upstream SDK so there's nothing in-repo to verify beyond the version bump, which CI confirms builds and passes tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades
massdriver-sdk-gofrom v0.2.14 → v0.2.17, which fixes two issues surfaced by agent sessions.1.
list_resource_grantswas unusable on any resource with a scoped grantListing grants on any resource carrying a scoped grant failed to decode:
The platform's grant read path serializes a single-valued condition as a bare
scalar string (
{"md-environment":"s3demo-demo"}), but the SDK'sPolicyConditions.UnmarshalJSONonly accepted"*"or a JSON array — so the entiregrant page failed to unmarshal, and there was no way to enumerate grants before
creating one. Fixed in the SDK (
UnmarshalJSONnow promotes a bare scalar to asingle-element set;
"*"still maps to the wildcard). This repo just picks up thefix via the dependency bump — the decode happens inside
Instances/Resourcesbefore the tool sees anything, so there's no in-repo code to change.
2.
get_instancenow returns incoming dependenciesAgents couldn't see what was wired into an instance. The SDK's
instances.Getnowpopulates
Instance.Dependencies(the filled connection slots — the upstreamresources feeding the instance). Because the handler serializes the full
Instance,this flows through automatically; the change here is to document it on the tool so
callers know to look, plus a test asserting dependencies serialize.
Changes
go.mod/go.sum: massdriver-sdk-go v0.2.14 → v0.2.17get_instancedescription: note thatdependencies(incoming connections) are returnedTestHandleGetInstancenow covers an instance with a populated dependencyVerification
go build ./...,go vet ./...clean