Repository navigation
Develop - #48
Merged
Merged
Develop#48
Conversation
Use a linear email pattern in the training application
Bumps [tauri-build](https://github.com/tauri-apps/tauri) from 2.7.3 to 2.7.4. - [Release notes](https://github.com/tauri-apps/tauri/releases) - [Commits](tauri-apps/tauri@tauri-build-v2.7.3...tauri-build-v2.7.4) --- updated-dependencies: - dependency-name: tauri-build dependency-version: 2.7.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@tauri-apps/cli](https://github.com/tauri-apps/tauri) from 2.12.3 to 2.12.4. - [Release notes](https://github.com/tauri-apps/tauri/releases) - [Commits](https://github.com/tauri-apps/tauri/compare/@tauri-apps/cli-v2.12.3...@tauri-apps/cli-v2.12.4) --- updated-dependencies: - dependency-name: "@tauri-apps/cli" dependency-version: 2.12.4 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [tauri](https://github.com/tauri-apps/tauri) from 2.12.4 to 2.12.5. - [Release notes](https://github.com/tauri-apps/tauri/releases) - [Commits](tauri-apps/tauri@tauri-v2.12.4...tauri-v2.12.5) --- updated-dependencies: - dependency-name: tauri dependency-version: 2.12.5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…entry points Adds tsconfig.core.json (core/<area>/typed to core/generated), shared text and session-data helpers with unknown-validated JSON reading, and keeps the recorded report output identical.
…ies and list the bundled driver advisories explicitly
Fix production dependency advisories
Migrate the report writers to TypeScript
…tauri-apps/cli-2.12.4' into chore/tauri-updates
…op/tauri-2.12.5' into chore/tauri-updates
…op/tauri-build-2.7.4' into chore/tauri-updates
Update tauri, tauri-build and the Tauri CLI
Point contributors to the current-position summary
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
There was a problem hiding this comment.
🟡 Changes recommended
Missing build hooks cause autoflow and replay to fail on a fresh installation with MODULE_NOT_FOUND for required report modules under core/generated.
1 open issue
1 file not reviewed
training/sample-site/server.js: Generated file
What changed in this PR
This PR advances the codebase’s incremental TypeScript migration by moving report generation into typed modules while retaining CommonJS entry points.
Changes:
- Migrates report writers and shared helpers, with characterization tests and golden outputs.
- Integrates report compilation into build and desktop packaging workflows.
- Updates dependencies, audit exceptions, and sample-site email validation.
| File | Description |
|---|---|
tsconfig.core.json |
Adds strict compilation for typed report modules. |
training/sample-site/server.js |
Tightens email length and domain validation. |
test/reportCharacterization.test.js |
Adds report output and parser regression checks. |
test/golden/report/report.md |
Records expected Markdown session output. |
test/golden/report/report.html |
Records expected HTML session output. |
test/golden/report/replay-report.md |
Records expected Markdown replay output. |
test/golden/report/replay-report.html |
Records expected HTML replay output. |
test/golden/report/explore-report.html |
Records expected exploration output. |
test/golden/report/empty-report.md |
Records expected empty-session output. |
src-tauri/Cargo.lock |
Updates Tauri and image dependencies. |
scripts/prepare-desktop.js |
Compiles reports and excludes typed sources from packaging. |
scripts/audit-gate.js |
Expands time-limited bundled-driver advisory exceptions. |
package.json |
Adds report compilation and updates dependency overrides. |
package-lock.json |
Locks updated JavaScript dependencies. |
eslint.config.mjs |
Excludes generated report JavaScript from linting. |
core/report/typed/text.ts |
Centralizes report text and formatting helpers. |
core/report/typed/sessionData.ts |
Adds typed session artifact readers. |
core/report/typed/replayReport.ts |
Migrates replay parsing and report generation. |
core/report/typed/markdownReport.ts |
Migrates Markdown session reporting. |
core/report/typed/htmlReport.ts |
Migrates HTML session reporting. |
core/report/typed/exploreReport.ts |
Migrates exploration reporting. |
core/report/replayReport.js |
Becomes a CommonJS compatibility facade. |
core/report/markdownReport.js |
Becomes a CommonJS compatibility facade. |
core/report/htmlReport.js |
Becomes a CommonJS compatibility facade. |
core/report/exploreReport.js |
Becomes a CommonJS compatibility facade. |
AGENTS.md |
Expands internal progress-document reading guidance. |
.gitignore |
Ignores generated core JavaScript. |
Review effort: Balanced
| "verifier:test": "node --test test/verifier.test.js test/verifierHttpRunner.test.js test/verifierCampaign.test.js", | ||
| "build:verifier": "tsc -p tsconfig.verifier.json && tsc -p tsconfig.server.json && tsc -p tsconfig.verifier-ui.json", | ||
| "typecheck": "tsc -p tsconfig.verifier.json --noEmit && tsc -p tsconfig.server.json --noEmit && tsc -p tsconfig.verifier-ui.json --noEmit", | ||
| "build:verifier": "tsc -p tsconfig.verifier.json && tsc -p tsconfig.core.json && tsc -p tsconfig.server.json && tsc -p tsconfig.verifier-ui.json", |
Always run the Windows installer check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.