Repository navigation
Address code scanning findings - #38
Merged
Merged
Conversation
Sync develop with main
…tern, fuller escaping and rate limits Open files without following links and inspect the handle instead of checking first, verify the Node archive before saving it, escape backslashes in generated markup and selectors, restrict desktop file routes and apply rate limits, and use an own-property allowlist in the training site.
Address code scanning findings
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const partial = archive + '.partial'; fs.writeFileSync(partial,Buffer.from(await response.arrayBuffer())); fs.renameSync(partial,archive); | ||
| const body = Buffer.from(await response.arrayBuffer()); | ||
| if (crypto.createHash('sha256').update(body).digest('hex') !== expected) throw new Error('Node checksum mismatch; nothing was saved. Retry the download.'); | ||
| const partial = archive + '.partial'; fs.writeFileSync(partial,body); fs.renameSync(partial,archive); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Race-free file reads, a linear path pattern, fuller escaping, rate-limited desktop file routes and a stricter training-site language allowlist.