Add regression E2E test to verify PWA pull-to-refresh is disabled - #19
Closed
martinezharo wants to merge 1 commit into
Closed
Add regression E2E test to verify PWA pull-to-refresh is disabled#19martinezharo wants to merge 1 commit into
martinezharo wants to merge 1 commit into
Conversation
Contributor
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
klipcode | a86e89f | Commit Preview URL Branch Preview URL |
Jul 28 2026, 08:48 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
overscroll-behavior-y: noneapplies when running indisplay-mode: standalone.Description
e2e/smoke.spec.tsthat inspectsdocument.styleSheetsand verifies a@media (display-mode: standalone)rule setsoverscroll-behavior-y: noneforhtml, body.src/app/pwa.css(which contains the@media (display-mode: standalone)rule) and rely on the test to detect regressions.Testing
pnpm exec playwright test e2e/smoke.spec.ts --project=chromium --grep 'installed PWA disables', which passed.pnpm exec eslint e2e/smoke.spec.ts, which returned clean results for the change.pnpm test, which completed successfully (13 files, 146 tests passed).Codex Task